Skip to content

shadow,tcpreplay,stress-ng: bump versions #30251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
commodo wants to merge 3 commits into
base: master
Choose a base branch
from
Open

shadow,tcpreplay,stress-ng: bump versions #30251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
119603e
shadow: update to 4.20.2
commodo Aug 9, 2026
b3f60fb
tcpreplay: update to 4.6.0
commodo Aug 9, 2026
e912acc
stress-ng: update to 0.21.04
commodo Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions net/tcpreplay/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
include $(TOPDIR)/rules.mk

PKG_NAME:=tcpreplay
PKG_VERSION:=4.5.2
PKG_RELEASE:=5
PKG_VERSION:=4.6.0
PKG_RELEASE:=1

PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
PKG_SOURCE_URL:=https://github.com/appneta/tcpreplay/releases/download/v$(PKG_VERSION)
PKG_HASH:=2df15bc6d49f96a77617d137049f998193bbae95c1a31b04ca02856a24cbf384
PKG_HASH:=1ec01a3fab92215be6d8a99984ab6c16047c1ec6d813f4c508b744dd94b48837

PKG_LICENSE:=GPL-3.0-only
PKG_LICENSE_FILES:=docs/LICENSE
Expand Down
6 changes: 3 additions & 3 deletions utils/shadow/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
include $(TOPDIR)/rules.mk

PKG_NAME:=shadow
PKG_VERSION:=4.19.4
PKG_RELEASE:=2
PKG_VERSION:=4.20.2

@openwrt-ai openwrt-ai Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shadow 4.20 dropped three of the applets this package still builds, so this bump breaks the build.

src/expiry.c, src/groupmems.c and src/logoutd.c are gone from the 4.20.2 release tarball (tar tJf shadow-4.20.2.tar.xz | grep -E 'src/(expiry|groupmems|logoutd)\.c' returns nothing; they are all present in 4.19.4), and src/Makefile.am no longer lists them:

-ubin_PROGRAMS  = faillog chage chfn chsh expiry gpasswd newgrp passwd
+ubin_PROGRAMS  = faillog chage chfn chsh gpasswd newgrp passwd
 usbin_PROGRAMS = \
-	groupmems \
-	logoutd \

They are still in SHADOW_APPLETS, so GenPlugin/BuildPlugin still emit shadow-expiry, shadow-groupmems and shadow-logoutd, and their install recipe falls through to $(CP) $(PKG_INSTALL_DIR)/usr/bin/$(1) with no such file. shadow-all defaults to y, so this is hit in a default build. Please drop expiry, groupmems and logoutd from SHADOW_APPLETS in this commit (and mention the removed packages in the commit message).

Generated by Claude Code

PKG_RELEASE:=1

PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
PKG_SOURCE_URL:=https://github.com/shadow-maint/shadow/releases/download/$(PKG_VERSION)
PKG_HASH:=ce57a313e315a0a7cb04a8f50cc20753e994e487bbe9b78a2a824ca75cb486c0
PKG_HASH:=b89f432b75ae55a2d852b446d0365484795fdf533ab97d550e325fa15594a224

@openwrt-ai openwrt-ai Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the 4.20.2 tarball the bcrypt sed becomes a silent no-op, so the shipped login.defs loses ENCRYPT_METHOD entirely.

In 4.19.4 etc/login.defs carried #ENCRYPT_METHOD DES; in 4.20.2 the commented default is #ENCRYPT_METHOD SHA512 (line 366 of the tarball's etc/login.defs), and etc/Makefile.am installs the file verbatim (sysconf_DATA = login.defs, no substitution). So $(SED) 's,#ENCRYPT_METHOD DES,ENCRYPT_METHOD BCRYPT,g' matches nothing and /etc/login.defs ends up with every ENCRYPT_METHOD line commented out — the package silently stops defaulting to bcrypt even though --with-bcrypt is still configured. The pattern needs to be updated to the new commented line (#ENCRYPT_METHOD SHA512).

(The SU_NAME sed above it is unaffected — SU_NAME su is still at line 123.)

Generated by Claude Code


PKG_MAINTAINER:=Alexandru Ardelean <ardeleanalex@gmail.com>
PKG_LICENSE:=BSD-3-Clause
Expand Down
2 changes: 1 addition & 1 deletion utils/shadow/patches/004-fix-su-controoling-term.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
--- a/src/su.c
+++ b/src/su.c
@@ -1169,8 +1169,12 @@ int main (int argc, char **argv)
@@ -1165,8 +1165,12 @@ int main (int argc, char **argv)

if (fd >= 0) {
err = ioctl (fd, TIOCNOTTY, (char *) NULL);
Expand Down
6 changes: 3 additions & 3 deletions utils/stress-ng/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
include $(TOPDIR)/rules.mk

PKG_NAME:=stress-ng
PKG_VERSION:=0.21.03
PKG_RELEASE:=2
PKG_VERSION:=0.21.04

@openwrt-ai openwrt-ai Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.21.04 adds two new library probes this package doesn't pin, which makes the resulting binary depend on what else happens to be in staging_dir.

Makefile.config in 0.21.04 gained:

LIB_NL := -lnl-3 -lnl-genl-3
LIB_GENL := -lnl-genl-3
...
libraries: ... LIB_LZMA LIB_NL LIB_GENL
LIB_NL:
	$(call check_lib,test-lnl,HAVE_LIB_NL,-lnl-3 -lnl-genl-3,$(LIB_NL),$(CFLAGS_NL))

Neither NL nor GENL is in STRESS_NG_LIBS or in the "never probe for them" block, so the probe runs with its default non-empty value. libnl is available in OpenWrt and stages both the headers and libnl-3.so/libnl-genl-3.so via Build/InstallDev in package/libs/libnl, so in a feed-wide build the check succeeds and stress-ng links -lnl-3 -lnl-genl-3 while DEPENDS names no libnl package — a broken runtime dependency, and a build whose output differs depending on whether libnl was staged.

Either add them to the never-probe block (LIB_NL= / LIB_GENL=), or give them STRESS_NG_LIB_NL / STRESS_NG_LIB_GENL symbols in Config.in with +libnl-genl in DEPENDS, consistent with the other optional libraries.

(FWIW the patch drop in this commit checks out: check_lib and check_lib_apparmor are both present in upstream Makefile.config at tag V0.21.04, and every LIB_* this package empties goes through them.)

Generated by Claude Code

PKG_RELEASE:=1

PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
PKG_SOURCE_URL:=https://codeload.github.com/ColinIanKing/stress-ng/tar.gz/refs/tags/V$(PKG_VERSION)?
PKG_HASH:=6db7089ad9cc2c13d0aa1cf8755112adac92858f4582a46c765bb6b7e1c3e1af
PKG_HASH:=a328ba050bd3014f07a3265fb6c1aab071ae942dfad75c7459cce45a987869e1

PKG_MAINTAINER:=Alexandru Ardelean <ardeleanalex@gmail.com>
PKG_LICENSE:=GPL-2.0-only
Expand Down
141 changes: 0 additions & 141 deletions utils/stress-ng/patches/001-allow-external-library-checks-to-be-disabled.patch
View file
Open in desktop

This file was deleted.

Loading