Skip to content

nmap: update to 7.991 - #30261

Open
AuthorReflex wants to merge 1 commit into
openwrt:masterfrom
AuthorReflex:nmap-7.991
Open

nmap: update to 7.991#30261
AuthorReflex wants to merge 1 commit into
openwrt:masterfrom
AuthorReflex:nmap-7.991

Conversation

@AuthorReflex

@AuthorReflex AuthorReflex commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

📦 Package Details

Maintainer: @nunojpg

Description:
Changelog: https://nmap.org/changelog.html#7.991

Add patch to fix compilation when NOLUA flag is defined - upstream accepted
Add git am header to 030-ncat-drop-ca-bundle.patch, refresh patches


🧪 Run Testing Details

  • OpenWrt Version: trunk
  • OpenWrt Target/Subtarget: ramips/mt7621, mediatek/filogic
  • OpenWrt Device: Xiaomi Mi4 GE, Netis N6 V2

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@AuthorReflex
AuthorReflex force-pushed the nmap-7.991 branch 2 times, most recently from 931924a to e7efcbb Compare August 12, 2026 09:32
@AuthorReflex
AuthorReflex marked this pull request as ready for review August 12, 2026 09:56

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit. PKG_VERSION bump with PKG_RELEASE:=1 and the two hunk-header-only refreshes look right, and the new #ifndef NOLUA guard matches how nse_main.h is included in nmap.cc, so it covers the --without-liblua variants (nmap/nmap-ssl, ncat/ncat-ssl, nping*) that currently fail to link close_nse().

Nothing here blocks a merge — the two inline remarks are patch-format nits. Note I could not fetch nmap.org from this environment, so PKG_HASH for 7.991 is unverified on my side; the package build jobs were still running at review time.


Generated by Claude Code

Comment thread net/nmap/patches/001-Fix-compilation-when-NOLUA-flag-is-defined.patch Outdated
Comment thread net/nmap/patches/030-ncat-drop-ca-bundle.patch Outdated
Changelog: https://nmap.org/changelog.html#7.991

Add patch to fix compilation when NOLUA flag is defined.
Add git am header to 030-ncat-drop-ca-bundle.patch, refresh patches

Signed-off-by: Ivan Pavlov <AuthorReflex@gmail.com>

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit; no new issues found.

The re-push only touches the two patch headers I commented on last time: 001-Fix-compilation-when-NOLUA-flag-is-defined.patch now has the Fixes: trailer on one line and the trailing spaces gone, and 030-ncat-drop-ca-bundle.patch has the redundant Author:/Title: pseudo-headers dropped with the Subject: line carrying the original wording. The Makefile hunk (PKG_VERSION 7.991, PKG_RELEASE:=1, new PKG_HASH) and the #ifndef NOLUA guard are unchanged from the version I reviewed before.

PKG_HASH for 7.991 remains unverified on my side — nmap.org is not reachable from this environment. The Feeds Package Test Build failures on the current head are in unrelated packages' runtime tests (the failing jobs get all the way through the alphabetical test list to xz/zstd, and four architectures pass), so I don't read them as caused by this change.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants