nmap: update to 7.991 - #30261
Conversation
931924a to
e7efcbb
Compare
e7efcbb to
ee656c9
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit. PKG_VERSION bump with PKG_RELEASE:=1 and the two hunk-header-only refreshes look right, and the new #ifndef NOLUA guard matches how nse_main.h is included in nmap.cc, so it covers the --without-liblua variants (nmap/nmap-ssl, ncat/ncat-ssl, nping*) that currently fail to link close_nse().
Nothing here blocks a merge — the two inline remarks are patch-format nits. Note I could not fetch nmap.org from this environment, so PKG_HASH for 7.991 is unverified on my side; the package build jobs were still running at review time.
Generated by Claude Code
0ab1fab to
0e5afd5
Compare
Changelog: https://nmap.org/changelog.html#7.991 Add patch to fix compilation when NOLUA flag is defined. Add git am header to 030-ncat-drop-ca-bundle.patch, refresh patches Signed-off-by: Ivan Pavlov <AuthorReflex@gmail.com>
0e5afd5 to
4dfe255
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; no new issues found.
The re-push only touches the two patch headers I commented on last time: 001-Fix-compilation-when-NOLUA-flag-is-defined.patch now has the Fixes: trailer on one line and the trailing spaces gone, and 030-ncat-drop-ca-bundle.patch has the redundant Author:/Title: pseudo-headers dropped with the Subject: line carrying the original wording. The Makefile hunk (PKG_VERSION 7.991, PKG_RELEASE:=1, new PKG_HASH) and the #ifndef NOLUA guard are unchanged from the version I reviewed before.
PKG_HASH for 7.991 remains unverified on my side — nmap.org is not reachable from this environment. The Feeds Package Test Build failures on the current head are in unrelated packages' runtime tests (the failing jobs get all the way through the alphabetical test list to xz/zstd, and four architectures pass), so I don't read them as caused by this change.
Generated by Claude Code
📦 Package Details
Maintainer: @nunojpg
Description:
Changelog: https://nmap.org/changelog.html#7.991
Add patch to fix compilation when NOLUA flag is defined - upstream accepted
Add git am header to 030-ncat-drop-ca-bundle.patch, refresh patches
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.