k3screenctrl: add new package - #30281
Conversation
dc60772 to
5557a0c
Compare
k3screenctrl is the package that drives the screen of Phicomm K3. Signed-off-by: Kazuto Iris <hitomi@apache.org>
5557a0c to
e83f3b6
Compare
| PKG_LICENSE:=GPL-2.0-only | ||
| PKG_LICENSE_FILES:=COPYING | ||
| PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz | ||
| PKG_SOURCE_URL:=https://github.com/kazutoiris/k3screenctrl/archive/refs/tags/v$(PKG_VERSION).tar.gz? |
There was a problem hiding this comment.
Why not use https://github.com/lwz322/k3screenctrl ? Your repository is only 2 commits ahead of that repository and there is no pull request to the upstream repository.
Also ping @zxlhhyccc who created https://github.com/zxlhhyccc/Hill-98-k3screenctrl
There was a problem hiding this comment.
Since most of the authors/modifiers are no longer reachable, I currently use the Phicomm K3 and will continue to maintain it.
There was a problem hiding this comment.
4 days ago. Hmm, still I would like to see pull request there.
There was a problem hiding this comment.
Since the most recent commit for lwz322/k3screenctrl was made 3 years ago, and zxlhhyccc/Hill-98-k3screenctrl was made 7 years ago, many maintainers have abandoned the Phicomm K3. Of course, if you are willing to wait, I don't mind.
| PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz | ||
| PKG_SOURCE_URL:=https://github.com/kazutoiris/k3screenctrl/archive/refs/tags/v$(PKG_VERSION).tar.gz? | ||
| PKG_HASH:=cc9927f324ce7e221a2ac3351ec78156719195662cc5bafd5424d340c170cd39 | ||
| PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)-$(PKG_VERSION) |
There was a problem hiding this comment.
This is already default, so it can be dropped.
There was a problem hiding this comment.
It seems that only PKG_BUILD_DIR matches the default value.
While PKG_SOURCE, PKG_SOURCE_URL, and PKG_HASH all differ from it.
Am I misunderstanding something?
📦 Package Details
Maintainer: @kazutoiris
Description:
k3screenctrl is the package that drives the screen of Phicomm K3. If it is not installed, the screen will always stay on and display "Rebooting". Therefore, this package is essential for all Phicomm K3 users.
Over the past 10 years, this package was hosted in different maintainers' repositories, and all users have to search and compile it on their own.
🧪 Run Testing Details
✅ Formalities