Skip to content

croc: update to v11.1.1 - #30283

Open
jonasjelonek wants to merge 1 commit into
openwrt:masterfrom
jonasjelonek:croc-update
Open

croc: update to v11.1.1#30283
jonasjelonek wants to merge 1 commit into
openwrt:masterfrom
jonasjelonek:croc-update

Conversation

@jonasjelonek

@jonasjelonek jonasjelonek commented Aug 15, 2026

Copy link
Copy Markdown
Member

A lot of changes and commits across various release tags. Full diff can be found at schollz/croc@v10.3.1...v11.1.1

A lot of changes and commits across various release tags.
Full diff can be found at schollz/croc@v10.3.1...v11.1.1

Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit. Nothing here blocks a merge — the only finding is a nit on the PR title.

Verified against the upstream tree at v11.1.1:

  • Module pathgo.mod declares module github.com/schollz/croc/v11, so the GO_PKG bump from /v10 to /v11 is required and correct.
  • GO_PKG_LDFLAGS_X — v11 moved the version to var Version = buildversion.Value in src/cli/cli.go. Since src/version.Value is a const, that is still a static initialization, so -X .../src/cli.Version= continues to take effect. The generic CI version check will keep passing (and did).
  • Go toolchain — v11 raises the directive from go 1.24.0 to go 1.26.0. The feed's GO_DEFAULT_VERSION is 1.26 and golang1.26 ships 1.26.6, so this is satisfied; there is no toolchain directive that would trigger a toolchain download.
  • Dependencies — the go.mod delta is pure Go (schollz/cli/v2 dropped in favour of the in-tree internal/cli, coder/websocket and the mattn terminal libs added). No cgo outside tests, so DEPENDS:=$(GO_ARCH_DEPENDS) is unchanged for good reason.
  • PKG_RELEASE — already 1 and correctly left at 1 for a version upgrade.
  • License / CPELICENSE is still MIT and cpe:/a:schollz:croc still applies.
  • DefaultsDEFAULT_RELAY/DEFAULT_PORT are unchanged from v10, and the package ships no init script or config, so there is nothing else to migrate.

GO_PKG_BUILD_PKG:=$(GO_PKG) keeps the build scoped to the root main package, so the new cmd/croc-web binary added in v11 is intentionally not built — flagging only so it is a conscious choice rather than an oversight.

I could not fetch the release tarball to check PKG_HASH directly (egress restriction), but all ten architecture build jobs succeeded on this head, which exercises the download and hash check.


Generated by Claude Code

Comment thread net/croc/Makefile
@jonasjelonek jonasjelonek changed the title croc: update to v11.1.0 croc: update to v11.1.1 Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants