croc: update to v11.1.1 - #30283
Open
jonasjelonek wants to merge 1 commit into
Open
Conversation
A lot of changes and commits across various release tags. Full diff can be found at schollz/croc@v10.3.1...v11.1.1 Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
jonasjelonek
force-pushed
the
croc-update
branch
from
August 15, 2026 21:36
5c45048 to
2a726db
Compare
openwrt-ai
reviewed
Aug 16, 2026
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 1 new commit. Nothing here blocks a merge — the only finding is a nit on the PR title.
Verified against the upstream tree at v11.1.1:
- Module path —
go.moddeclaresmodule github.com/schollz/croc/v11, so theGO_PKGbump from/v10to/v11is required and correct. GO_PKG_LDFLAGS_X— v11 moved the version tovar Version = buildversion.Valueinsrc/cli/cli.go. Sincesrc/version.Valueis aconst, that is still a static initialization, so-X .../src/cli.Version=continues to take effect. The generic CI version check will keep passing (and did).- Go toolchain — v11 raises the directive from
go 1.24.0togo 1.26.0. The feed'sGO_DEFAULT_VERSIONis1.26andgolang1.26ships 1.26.6, so this is satisfied; there is notoolchaindirective that would trigger a toolchain download. - Dependencies — the go.mod delta is pure Go (
schollz/cli/v2dropped in favour of the in-treeinternal/cli,coder/websocketand themattnterminal libs added). No cgo outside tests, soDEPENDS:=$(GO_ARCH_DEPENDS)is unchanged for good reason. PKG_RELEASE— already1and correctly left at1for a version upgrade.- License / CPE —
LICENSEis still MIT andcpe:/a:schollz:crocstill applies. - Defaults —
DEFAULT_RELAY/DEFAULT_PORTare unchanged from v10, and the package ships no init script or config, so there is nothing else to migrate.
GO_PKG_BUILD_PKG:=$(GO_PKG) keeps the build scoped to the root main package, so the new cmd/croc-web binary added in v11 is intentionally not built — flagging only so it is a conscious choice rather than an oversight.
I could not fetch the release tarball to check PKG_HASH directly (egress restriction), but all ten architecture build jobs succeeded on this head, which exercises the download and hash check.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of changes and commits across various release tags. Full diff can be found at schollz/croc@v10.3.1...v11.1.1