-
Notifications
You must be signed in to change notification settings - Fork 453
bmx7: clean up Makefile and add test-version.sh #1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BKPepe
wants to merge
5
commits into
openwrt:openwrt-25.12
Choose a base branch
from
BKPepe:bmx7-cleanup
base: openwrt-25.12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
207c5a8
bmx7: clean up Makefile
BKPepe d5bf0be
bmx7: add test-version.sh for CI runtime tests
BKPepe 6e1e587
bmx7: correct the reason recorded in test-version.sh
BKPepe e42b199
bmx7: add the trailing slash to the /etc/bmx7 conffiles entry
BKPepe 9f99383
bmx7: build in parallel
BKPepe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| #!/bin/sh | ||
|
|
||
| # shellcheck shell=busybox | ||
|
|
||
| case "$PKG_NAME" in | ||
| bmx7) | ||
| # The version of bmx7 is derived from the source date, which the | ||
| # binary does not report. `bmx7 -v` is not an alternative: the | ||
| # key path option is applied before the version option, so a | ||
| # missing node key gets generated first - "Creating RSA2048 | ||
| # private key. This can take a while", as bmx7 puts it. | ||
| exit 0 | ||
| ;; | ||
|
|
||
| bmx7-*) | ||
| # Plugins are libraries and do not provide version information | ||
| exit 0 | ||
| ;; | ||
|
|
||
| *) | ||
| echo "Untested package: $PKG_NAME" >&2 | ||
| exit 1 | ||
| ;; | ||
| esac | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@axn — question rather than a bug report: bmx7 -v prints the node identity (key hash, key type, link keys, descSqn), so it needs myKey and therefore generates the RSA2048 node key on first run before printing anything. That is fine for what the option does, but it means there is no cheap way to ask a bmx7 binary which version it is, which is why this PR skips the version check in CI rather than running the binary.
Would a lightweight option that prints just BMX_BRANCH-BRANCH_VERSION and exits be of interest upstream?