Skip to content

Disable singing of commits in tests#4890

Merged
vladak merged 1 commit intooracle:masterfrom
gaborbernat:fix-git-signing-tests
Jan 5, 2026
Merged

Disable singing of commits in tests#4890
vladak merged 1 commit intooracle:masterfrom
gaborbernat:fix-git-signing-tests

Conversation

@gaborbernat
Copy link
Copy Markdown
Contributor

@gaborbernat gaborbernat commented Dec 16, 2025

This can causes tests to fail where is setup and require user input.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 16, 2025
@gaborbernat gaborbernat force-pushed the fix-git-signing-tests branch from f572000 to 9166ae2 Compare December 16, 2025 19:57
@gaborbernat gaborbernat changed the title fix git signing tests Disable singing of commits in tests Dec 16, 2025
@gaborbernat gaborbernat force-pushed the fix-git-signing-tests branch from 9166ae2 to 39be9e6 Compare December 16, 2025 19:58
On machines where signing commits requires input these tests will make it failing,
and is not really revelvant for the test.

Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat force-pushed the fix-git-signing-tests branch from 39be9e6 to b20bdbe Compare January 3, 2026 00:37
@gaborbernat
Copy link
Copy Markdown
Contributor Author

@vladak ran into this while trying to fix #4865, if you can accept it helps with that 👍

@vladak vladak merged commit f64b3b5 into oracle:master Jan 5, 2026
10 checks passed
@vladak
Copy link
Copy Markdown
Member

vladak commented Jan 5, 2026

Thanks !

There should probably be a wrapper method for this kind of operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants