CIEM-45:fix split#34
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the split issue by enhancing the policy expansion logic to group and merge actions based on their source, action, resource, and not_resource.
- Introduces grouping of actions into a dictionary by source/action/resource/not_resource.
- Implements merging of multiple actions’ conditions when they share the same key.
- Updates subsequent processing to iterate over the merged actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in our policy compression logic where multiple condition operators from the same policy statement were not being properly preserved. Specifically, when a statement included both StringEquals and StringEqualsIfExists condition operators, only one of them would be retained after compression—resulting in loss of policy intent.
To address this, the logic has been updated to group and merge Action objects that originate from the same source statement. This grouping is based on matching the source, action, resource, and not_resource fields. When such matches are found, their conditions are merged to ensure that all applicable operators are retained in the final compressed policy.