Skip to content

BP5/XRootD: identity/version/byte-order checks on remote reads#5060

Merged
eisenhauer merged 1 commit into
ornladios:masterfrom
eisenhauer:xrootd-metadata-identity
Jun 4, 2026
Merged

BP5/XRootD: identity/version/byte-order checks on remote reads#5060
eisenhauer merged 1 commit into
ornladios:masterfrom
eisenhauer:xrootd-metadata-identity

Conversation

@eisenhauer
Copy link
Copy Markdown
Member

This PR is in some sense a roll-up of new information that may be (but likely currently isn't) part of an HTTPS request. This items include :

  • the UUID of the file requested to ensure it matches what the remote has (omitted for UUID=0, which is true for all files except BP5 files newer than PR BP5: add per-file id to index header #5057).
  • the byte order of the requesting client (omitted if little-endian).
  • a request-version number (omitted if zero, which it currently is, but here to handle the inevitable changes).

- client sends its file id; server rejects a stale-metadata mismatch
- server parses/polices a request version and client byte order (rejects cross-endian)
- all request rejections recorded in the access log
@eisenhauer eisenhauer force-pushed the xrootd-metadata-identity branch from 87b43f7 to 8c10be6 Compare June 4, 2026 16:20
@eisenhauer eisenhauer requested a review from pnorbert June 4, 2026 19:39
@eisenhauer
Copy link
Copy Markdown
Member Author

The SPIN-deployed server is now running with these changes and it properly rejects queries to files with the right path but the wrong metadata UUID. This, plus the in-CI XRootD tests (which will exercise the matching-UUID path). Should be sufficient testing for now. We've added a version number to the request to cover the circumstance where we change the format and want to throw errors on server/request mismatch (no changes anticipated yet). We've also got the client byte-order in the request, should the world get more heterogeneous again...

@eisenhauer eisenhauer merged commit 51ea7a8 into ornladios:master Jun 4, 2026
48 checks passed
@eisenhauer eisenhauer deleted the xrootd-metadata-identity branch June 4, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants