BP5/XRootD: identity/version/byte-order checks on remote reads#5060
Merged
Conversation
- client sends its file id; server rejects a stale-metadata mismatch - server parses/polices a request version and client byte order (rejects cross-endian) - all request rejections recorded in the access log
87b43f7 to
8c10be6
Compare
Member
Author
|
The SPIN-deployed server is now running with these changes and it properly rejects queries to files with the right path but the wrong metadata UUID. This, plus the in-CI XRootD tests (which will exercise the matching-UUID path). Should be sufficient testing for now. We've added a version number to the request to cover the circumstance where we change the format and want to throw errors on server/request mismatch (no changes anticipated yet). We've also got the client byte-order in the request, should the world get more heterogeneous again... |
pnorbert
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is in some sense a roll-up of new information that may be (but likely currently isn't) part of an HTTPS request. This items include :