Fix nullable return in getUserIdentifier() when username is not set#1140
Open
Dylvn wants to merge 1 commit intooroinc:6.1from
Open
Fix nullable return in getUserIdentifier() when username is not set#1140Dylvn wants to merge 1 commit intooroinc:6.1from
Dylvn wants to merge 1 commit intooroinc:6.1from
Conversation
Member
|
Thank you for your pull request. It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://oroinc.com/b2b-ecommerce/contributor-license-agreement/ If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits. Once you've signed the CLA, please allow for some time for the submission to be processed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes oroinc/customer-portal#14
Problem
When importing
CustomerUserrecords without an ID (creation) and without an email address, aTypeErroris triggered during Symfony validation.The validator calls
__toString()on the freshly instantiated entity, which internally callsgetUserIdentifier():The
(string)cast never executes. TheTypeErroris raised insidegetUserIdentifier()itself, before the cast can apply.Root cause
$usernameis declared as?stringat the Doctrine level, which is a valid state during entity construction (e.g. import processing before the field is hydrated). However, Symfony'sUserInterfacecontract enforces a strictstringreturn type ongetUserIdentifier().Fix
Return an empty string as fallback to bridge the gap between the nullable Doctrine mapping and the strict Symfony interface contract.