Skip to content

OSAC-497: Fix overlay graph NAT rules layout#29

Open
danmanor wants to merge 1 commit intomainfrom
osac-497-fix-overlay-graph
Open

OSAC-497: Fix overlay graph NAT rules layout#29
danmanor wants to merge 1 commit intomainfrom
osac-497-fix-overlay-graph

Conversation

@danmanor
Copy link
Copy Markdown
Contributor

@danmanor danmanor commented May 7, 2026

Summary

  • Wraps the NAT rule nodes (SNAT/DNAT) inside a SoftGate subgraph in the overlay diagram
  • Fixes the disconnected lines between Internet and the NAT nodes caused by the ELK renderer spreading them too wide

@danmanor danmanor enabled auto-merge (squash) May 7, 2026 12:41
@danmanor
Copy link
Copy Markdown
Contributor Author

danmanor commented May 7, 2026

/cc @AlonaKaplan @mhrivnak

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bf017f3f-fba9-4fc3-9e4a-15d3dceb9eca

📥 Commits

Reviewing files that changed from the base of the PR and between 614f505 and 46c0629.

📒 Files selected for processing (1)
  • features/netris-caas-networking.md

Walkthrough

This pull request modifies the features/netris-caas-networking.md documentation file to restructure a Mermaid diagram representing the network overlay architecture. The change introduces a named subgraph labeled "SoftGate" that logically groups five SoftGate-related networking components: Mgmt SNAT, Mgmt API DNAT port 6443, Hosted Cluster API DNAT port 6443, Cluster SNAT, and Hosted Cluster Ingress DNAT ports 80/443. These elements were previously listed in the main diagram body and are now contained within the subgraph block, improving diagram readability without altering their labels or connections.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • osac-project/docs#28: Modifies the same Logical Overlay diagram in features/netris-caas-networking.md with related structural changes to SoftGate nodes.

Suggested reviewers

  • AlonaKaplan
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'OSAC-497: Fix overlay graph NAT rules layout' accurately describes the main change: reorganizing NAT rule nodes in a diagram to fix layout issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch osac-497-fix-overlay-graph

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant