Search favorites or tracks by name#1683
Merged
Merged
Conversation
alisa911
reviewed
May 2, 2026
# Conflicts: # map/src/manager/FavoritesManager.js
alisa911
reviewed
May 13, 2026
Contributor
|
alisa911
reviewed
May 13, 2026
…l is called every render
# Conflicts: # map/src/context/AppContext.js
Contributor
Fix b15d4b8 |
Contributor
|
Сlosed but not fixed |
alisa911
reviewed
May 20, 2026
# Conflicts: # map/src/infoblock/components/wpt/WptDetails.jsx
Contributor
There was a problem hiding this comment.
Pull request overview
Implements searching within user data (cloud tracks and favorites) by name to address issue #1065, integrating user-object hits into the existing search results flow and ensuring selected items can be opened and navigated back from.
Changes:
- Add client-side search hits for cloud tracks and favorites, merging them into the existing search results list.
- Update menu/infoblock navigation to support opening items from search and returning to search results.
- Add an end-to-end Selenium test covering search + open + delete flows for both tracks and favorites.
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/selenium/src/tests/search/36-search-track-and-favorite.mjs | Adds E2E coverage for searching/opening/removing tracks and favorites by name. |
| map/src/util/hooks/menu/useMenuDots.js | Includes selectedSearchObj when determining active menu context. |
| map/src/menu/tracks/CloudTrackItem.jsx | Refactors track info text formatting into a reusable helper. |
| map/src/menu/search/search/SearchResults.jsx | Adjusts search triggering and passes current location into items. |
| map/src/menu/search/search/SearchResultItem.jsx | Adds rendering/handling for GPX_TRACK and FAVORITE search hits. |
| map/src/menu/MainMenu.js | Adds support for opening “search-selected” objects and returning to results. |
| map/src/menu/favorite/FavoriteItem.jsx | Adds onOpen/hideActions/id to reuse FavoriteItem in search results. |
| map/src/menu/actions/HeaderHelper.js | Clears search selection state when closing a favorite opened from search. |
| map/src/map/util/MapManager.js | Registers an icon mapping for GPX track search hits. |
| map/src/map/layers/SearchLayer.js | Merges local favorites + track hits into search results and avoids map markers for them. |
| map/src/map/layers/FavoriteLayer.js | Keeps favorites visible when they appear in search results (incl. hidden groups). |
| map/src/manager/track/TracksManager.js | Prevents “opened from search” tracks from being saved as menu selection. |
| map/src/manager/SearchManager.js | Adds feature builders for searching favorites and cloud tracks; adds back-navigation helper. |
| map/src/manager/FavoritesManager.js | Refactors favorite open/select helpers and adds “open from search” entry point. |
| map/src/infoblock/components/wpt/WptDetails.jsx | Updates favorite close behavior to support returning to search results. |
| map/src/infoblock/components/InformationBlock.jsx | Adds back-navigation to search results when closing a track opened from search. |
| map/src/infoblock/components/favorite/WptEditPanel.jsx | Updates favorite opening to new openFavoriteObj signature. |
| map/src/context/AppContext.js | Adds searchCollator, selectedSearchObj, and searchFavoriteGroupIds state. |
| map/public/images/map_icons/ic_action_polygon_dark.svg | Adds new SVG used for GPX track search icon. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


#1065