fix: resolve KeyError in run.py and update Python version requirement - #188
Open
itxaiohanglover wants to merge 1 commit into
Open
fix: resolve KeyError in run.py and update Python version requirement#188itxaiohanglover wants to merge 1 commit into
itxaiohanglover wants to merge 1 commit into
Conversation
…oss-compass#117) - Fix KeyError in run.py: check if key exists in params dict before accessing it, preventing crash when optional params are missing - Update setup.py: python_requires from >=3.4 to >=3.8 to match the actual grimoire_elk dependency requirement - Update README: add Python >=3.8 requirement note Signed-off-by: itxaiohanglover <1531137510@qq.com>
itxaiohanglover
force-pushed
the
fix/keyerror-and-python-version
branch
from
July 6, 2026 05:21
9009c40 to
9d077bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #117
Changes
run.py— FixKeyErrorwhen optional params are missing fromconf.yamlkwargs[item] = None if params[item] and params[item] == 'None' else params[item]— crashes withKeyErrorwhen a key is not inparamskwargs[item] = None if item not in params or params[item] == 'None' else params[item]— safely handles missing keysrun.pysetup.py— Update Python version requirementpython_requiresfrom>=3.4to>=3.83.4, 3.5to3.8, 3.9, 3.10, 3.11grimoire_elkdependency (see grimoirelab-elk pyproject.toml)README.md— Add Python version requirement note### Requirementssection withPython >= 3.8noteTest plan
run.pyandsetup.pycompile successfully