This repository was archived by the owner on Jan 6, 2023. It is now read-only.
Conversation
|
Can one of the admins verify this patch? |
Contributor
|
@neofang7 What's the Upstream-Status to this? |
Author
|
@mythi @peijiajames @nwang2 |
Author
|
@mythi This patch is only to improve Ostro shutdown performance on GT boards. |
Contributor
|
@neofang7 to me it looks you are fixing an obvious upstream race condition (nothing Ostro specific). |
Fixes: IOTOS-1743 During Ostro shutdown, systemd-timesyncd service will start up to sync with time server. However, network services are very possible to be stopped before timesyncd starts up. So, add network.target dependency to timesyncd.service to garantee that timesyncd will be triggered before network services stop. Signed-off-by: neofang7 <neo.fang@intel.com>
Contributor
|
@neofang7 any update? |
1 similar comment
Contributor
|
@neofang7 any update? |
Contributor
|
Many systemd services, even the ones shipped with systemd itself have similar faults. However, you may want to use network-online.target instead, because for interfaces using DHCP the network.target is reached already before DHCP has successfully obtained an IP address... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: IOTOS-1743
During Ostro shutdown, systemd-timesyncd service will start up to sync
with time server. However, network services are very possible to be
stopped before timesyncd starts up. So, add network.target dependency to
timesyncd.service to garantee that timesyncd will be triggered before
network services stop.
Signed-off-by: neofang7 neo.fang@intel.com