AO3-7488 Prevent deleted and spam comments from being resubmitted to Akismet#5844
Open
marcus8448 wants to merge 2 commits into
Open
AO3-7488 Prevent deleted and spam comments from being resubmitted to Akismet#5844marcus8448 wants to merge 2 commits into
marcus8448 wants to merge 2 commits into
Conversation
Bilka2
reviewed
May 30, 2026
Comment on lines
+940
to
+942
| let(:comment) { build(:comment, approved: false, spam: true) } | ||
|
|
||
| before { comment.save!(validate: false) } |
Contributor
There was a problem hiding this comment.
We have create_invalid to make this a bit shorter. But that's a nitpick, so approving anyway, thank you!
Bilka2
approved these changes
May 30, 2026
might as well fix it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7488
Purpose
Restores the check that prevented comments that were deleted or already marked as spam from being submitted to Akismet
Plus a fix to the
#mark_as_ham!test where the comment would already be marked as legitimate due to the spam status being updated in the validations.Testing Instructions
Automated tests only. There isn’t an easy way to tell if a comment was actually sent to Akismet or not.
Credit
marcus8448 (he/him)