Conversation
|
Updated 9:08 PM PT - Oct 26th, 2025
❌ @sosukesuzuki, your commit 9118d17 has 1 failures in 🧪 To try this PR locally: bunx bun-pr 24116That installs a local version of the PR into your bun-24116 --bun |
WalkthroughAdds a runtime guard in the CMake build configuration that prevents building WebKit with ASAN enabled on Linux systems using musl. When this unsupported combination is detected, the build aborts with a fatal error and provides alternative options. Changes
Pre-merge checks✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Comment |
|
we could try enabling with ASAN |
What does this PR do?
Previously our build script displays the following error message, when running
bun run debugon Alpine:This isn't easy to understand.
This PR improves build error message for asan x musl.
How did you verify your code works?
Tested on my local env.