Skip to content

fix: heap buffer overflow in acmp pm #3545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
airween wants to merge 2 commits into
base: v2/master
Choose a base branch
from
+4 −3
Open

fix: heap buffer overflow in acmp pm #3545

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9722758
fix: heap buffer overflow in acmp pm
airween Apr 12, 2026
b293ed6
Merge branch 'v2/master' into v2/acmppmfix
airween Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apache2/acmp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,17 +514,18 @@ apr_status_t acmp_add_pattern(ACMP *parser, const char *pattern,
child->pattern = "";
child->letter = letter;
child->depth = i;
child->text = apr_pcalloc(parser->pool, strlen(pattern) + 2);
child->text = apr_pcalloc(parser->pool, i + 2);
/* ENH: Check alloc succeded */
for (j = 0; j <= i; j++) child->text[j] = pattern[j];
}
if (i == length - 1) {
if (child->is_last == 0) {
parser->dict_count++;
child->is_last = 1;
child->pattern = apr_pcalloc(parser->pool, strlen(pattern) + 2);
child->pattern = apr_pcalloc(parser->pool, length + 1);
/* ENH: Check alloc succeded */
strcpy(child->pattern, pattern);
memcpy(child->pattern, pattern, length);
child->pattern[length] = '\0';
}
child->callback = callback;
child->callback_data = data;
Expand Down
Loading