ci: initial acceptance test workflow

.github/workflows/ci.yml

@@ -27,3 +27,118 @@ jobs:
     uses: ./.github/workflows/php-unit.yml
     with:
       php-versions: '["8.3"]'
+
+  acceptance-api:
+    name: API Tests
+    uses: ./.github/workflows/acceptance.yml
+    with:
+      do-api-tests: true
+      server-folder: 'server'
+      test-suites: "[
+        'apiAuth',
+        'apiAuthOcs',
+        'apiAuthWebDav',
+        'apiCapabilities',
+        'apiComments',
+        'apiFavorites',
+        'apiMain',
+        'apiProvisioning-v1',
+        'apiProvisioning-v2',
+        'apiProvisioningGroups-v1',
+        'apiProvisioningGroups-v2',
+        'apiShareCreateSpecialToRoot1',
+        'apiShareCreateSpecialToRoot2',
+        'apiShareCreateSpecialToShares1',
+        'apiShareCreateSpecialToShares2',
+        'apiSharees',
+        'apiShareManagementBasicToRoot',
+        'apiShareManagementBasicToShares',
+        'apiShareManagementToRoot',
+        'apiShareManagementToShares',
+        'apiShareOperationsToRoot1',
+        'apiShareOperationsToRoot2',
+        'apiShareOperationsToShares1',
+        'apiShareOperationsToShares2',
+        'apiSharePublicLink1',
+        'apiSharePublicLink2',
+        'apiSharePublicLink3',
+        'apiShareReshareToRoot1',
+        'apiShareReshareToRoot2',
+        'apiShareReshareToRoot3',
+        'apiShareReshareToShares1',
+        'apiShareReshareToShares2',
+        'apiShareReshareToShares3',
+        'apiShareUpdateToRoot',
+        'apiShareUpdateToShares',
+        'apiTags',
+        'apiTranslation',
+        'apiTrashbin',
+        'apiTrashbinRestore',
+        'apiVersions',
+        'apiWebdavDelete',
+        'apiWebdavEtagPropagation1',
+        'apiWebdavEtagPropagation2',
+        'apiWebdavLocks',
+        'apiWebdavLocks2',
+        'apiWebdavLocks3',
+        'apiWebdavLocksUnlock',
+        'apiWebdavMove1',
+        'apiWebdavMove2',
+        'apiWebdavOperations',
+        'apiWebdavProperties1',
+        'apiWebdavProperties2',
+        'apiWebdavUpload1',
+        'apiWebdavUpload2',
+        'apiWebdavUploadTUS']"
+
+  acceptance-api-notifications:
+    name: API Tests Notifications
+    uses: ./.github/workflows/acceptance.yml
+    with:
+      do-api-tests: true
+      server-folder: 'server'
+      additional-app: 'notifications'
+      test-suites: "['apiSharingNotificationsToRoot', 'apiSharingNotificationsToShares']"
+
+  acceptance-api-previews:
+    name: API Tests Previews
+    uses: ./.github/workflows/acceptance.yml
+    with:
+      do-api-tests: true
+      additional-packages: 'imagemagick'
+      server-folder: 'server'
+      test-suites: "['apiWebdavPreviews']"
+
+  acceptance-api-federation:
+    name: API Tests Federation
+    uses: ./.github/workflows/acceptance.yml
+    with:
+      do-api-tests: true
+      server-folder: 'server'
+      federated-folder: 'federated'
+      test-suites: "['apiFederationToRoot1', 'apiFederationToRoot2', 'apiFederationToShares1', 'apiFederationToShares2']"
+
+  acceptance-cli:
+    name: CLI Tests
+    uses: ./.github/workflows/acceptance.yml
+    with:
+      do-cli-tests: true
+      server-folder: 'server'
+      test-suites: "['cliMain', 'cliTrashbin']"
+
+  acceptance-cli-email:
+    name: CLI Tests
+    uses: ./.github/workflows/acceptance.yml
+    with:
+      do-cli-tests: true
+      use-email-server: true
+      server-folder: 'server'
+      test-suites: "['cliProvisioning']"
+
+  acceptance-webui:
+    name: WebUI Tests
+    uses: ./.github/workflows/acceptance.yml
+    with:
+      do-webui-tests: true
+      server-folder: 'server'
+      test-suites: "['webUIComments']"

.github/workflows/php-unit.yml

@@ -18,15 +18,6 @@ jobs:
       matrix:
         php: ${{ fromJSON(inputs.php-versions) }}
         database: [sqlite]
-        include:
-          - php: "8.3"
-            database: "mysql:8.0"
-          - php: "8.3"
-            database: "mariadb:10.6"
-          - php: "8.3"
-            database: "mariadb:10.11"
-          - php: "8.3"
-            database: "postgres:10.21"
 
     services:
       mysql:
@@ -42,6 +33,8 @@ jobs:
           --health-interval=10s
           --health-timeout=5s
           --health-retries=3
+          --character-set-server=utf8mb4
+          --collation-server=utf8mb4_unicode_ci
         ports:
           - 3306:3306
       postgres:

apps/federation/lib/DbHandler.php

@@ -293,6 +293,9 @@ protected function hash($url) {
 	 * @return string
 	 */
 	protected function normalizeUrl($url) {
+		if ($url === null) {
+			$url = '';
+		}
 		$normalized = $url;
 
 		if (\strpos($url, 'https://') === 0) {

apps/files_sharing/lib/External/Manager.php

@@ -573,20 +573,28 @@ protected function testUrl(IClientService $clientService, string $remote, bool $
 	public function testRemoteUrl(IClientService $clientService, string $remote) {
 		$parsed_host = parse_url($remote, PHP_URL_HOST);
 		$parsed_port = parse_url($remote, PHP_URL_PORT);
+		$parsed_path = parse_url($remote, PHP_URL_PATH);
 		if (\is_string($parsed_host)) {
 			$remote = $parsed_host;
 			if ($parsed_port !== null) {
 				$remote .= ':' . $parsed_port;
 			}
+			if ($parsed_path !== null) {
+				$remote .= $parsed_path;
+			}
 		} else {
 			$string_to_parse = 'http://' . $remote;
 			$parsed_host = parse_url($string_to_parse, PHP_URL_HOST);
 			$parsed_port = parse_url($string_to_parse, PHP_URL_PORT);
+			$parsed_path = parse_url($string_to_parse, PHP_URL_PATH);
 			if (\is_string($parsed_host)) {
 				$remote = $parsed_host;
 				if ($parsed_port !== null) {
 					$remote .= ':' . $parsed_port;
 				}
+				if ($parsed_path !== null) {
+					$remote .= $parsed_path;
+				}
 			}
 		}
 		try {

lib/private/Files/Storage/Wrapper/Encryption.php

@@ -472,7 +472,7 @@ public function fopen($path, $mode) {
 					if (!empty($encryptionModuleId)) {
 						$encryptionModule = $this->encryptionManager->getEncryptionModule($encryptionModuleId);
 						$shouldEncrypt = true;
-					} elseif (empty($encryptionModuleId) && $info['encrypted'] === true) {
+					} elseif ($info !== false && $info->isEncrypted()) {
 						// we come from a old installation. No header and/or no module defined
 						// but the file is encrypted. In this case we need to use the
 						// OC_DEFAULT_MODULE to read the file