move front-io related sequencing logic into the server#2502
Open
Aaron-Hartwig wants to merge 4 commits intomasterfrom
Open
move front-io related sequencing logic into the server#2502Aaron-Hartwig wants to merge 4 commits intomasterfrom
Aaron-Hartwig wants to merge 4 commits intomasterfrom
Conversation
mkeeter
reviewed
May 8, 2026
mkeeter
reviewed
May 8, 2026
mkeeter
reviewed
May 8, 2026
mkeeter
reviewed
May 8, 2026
| self.bsp.set_power_enable(false)?; | ||
| // After removing power to the board we must reset its | ||
| // server | ||
| self.do_server_reset(); |
Collaborator
There was a problem hiding this comment.
Can you say more about why this is necessary?
Contributor
Author
There was a problem hiding this comment.
Since this task handles sequencing and maintains state related to components on the front-io board (FPGA configuration, LED driver state, etc), clearing any state and starting over is a clean way to start from scratch when it is powered back up. Do you take issue with that as a strategy, or just want more context in the comment above it?
mkeeter
reviewed
May 8, 2026
mkeeter
reviewed
May 8, 2026
mkeeter
reviewed
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Act III in the effort to decouple front-io related logic from board specific sequencers involves moving all the actual sequencing logic (e.g. FPGA bitstream loading) into the front-io-server. This diff is very noisy as a result of that, but the core logic in play here is not touched. The last piece to do here will be move all the transceivers and LED stuff over, but that warrants its own commit I think. I am bringing Medusa along for the ride for now even though it is untested. After the decoupling is complete I will have a follow on PR which was used to actually bring up that board.