WIP: what does ringbuf look like as a library#659
Draft
labbott wants to merge 21 commits into
Draft
Conversation
Early hubris archives were tagged with version v1.0.0. Newer versions are a single integer. Rather than hack around this in the version parsing, just remove the old cores.
When humility/hubris were first developed we didn't have many details of the hubris archive beyond "it's a zip". We've since developed a separate library for hubris manipulation. Let humility use it too.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 100 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 99 | 1 | 0 | 0 |
Click to see the invalid file list
- cmd/ringbuf/src/clap.rs
| @@ -0,0 +1,86 @@ | |||
| use clap::{CommandFactory, Parser}; | |||
There was a problem hiding this comment.
Suggested change
| use clap::{CommandFactory, Parser}; | |
| // This Source Code Form is subject to the terms of the Mozilla Public | |
| // License, v. 2.0. If a copy of the MPL was not distributed with this | |
| // file, You can obtain one at https://mozilla.org/MPL/2.0/. | |
| use clap::{CommandFactory, Parser}; |
mkeeter
force-pushed
the
mkeeter/hiffy-call-unpack
branch
from
34d42b2 to
9899a0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.