Make IP address validation lazier#668
Merged
Merged
Conversation
labbott
approved these changes
May 18, 2026
Contributor
labbott
left a comment
labbott
left a comment
There was a problem hiding this comment.
LGTM, you may want reviews from those who might have strong opinions about thiserror shaped things
mkeeter
force-pushed
the
mkeeter/lazy-ip-address
branch
from
0703187 to
9bee966
Compare
mkeeter
force-pushed
the
mkeeter/subcommand-enum
branch
2 times, most recently
from
914a821 to
8bc7cfb
Compare
mkeeter
force-pushed
the
mkeeter/lazy-ip-address
branch
from
9bee966 to
5be72a2
Compare
mkeeter
force-pushed
the
mkeeter/subcommand-enum
branch
from
8bc7cfb to
9b7da57
Compare
mkeeter
force-pushed
the
mkeeter/lazy-ip-address
branch
2 times, most recently
from
3d3115f to
39bea87
Compare
mkeeter
force-pushed
the
mkeeter/subcommand-enum
branch
from
9b7da57 to
1cefecd
Compare
mkeeter
force-pushed
the
mkeeter/lazy-ip-address
branch
from
39bea87 to
8e6b788
Compare
mkeeter
force-pushed
the
mkeeter/subcommand-enum
branch
from
1cefecd to
9474cbb
Compare
mkeeter
force-pushed
the
mkeeter/lazy-ip-address
branch
from
8e6b788 to
925eafc
Compare
mkeeter
force-pushed
the
mkeeter/subcommand-enum
branch
2 times, most recently
from
8c8ab59 to
d462926
Compare
mkeeter
force-pushed
the
mkeeter/lazy-ip-address
branch
from
925eafc to
1d1f33d
Compare
mkeeter
force-pushed
the
mkeeter/subcommand-enum
branch
from
d462926 to
9029fba
Compare
mkeeter
force-pushed
the
mkeeter/lazy-ip-address
branch
2 times, most recently
from
03a5bbb to
9f8f18d
Compare
mkeeter
force-pushed
the
mkeeter/subcommand-enum
branch
from
9029fba to
5aabda9
Compare
mkeeter
force-pushed
the
mkeeter/lazy-ip-address
branch
from
9f8f18d to
a375ce8
Compare
mkeeter
force-pushed
the
mkeeter/subcommand-enum
branch
2 times, most recently
from
282a801 to
7cf583b
Compare
mkeeter
force-pushed
the
mkeeter/lazy-ip-address
branch
from
a375ce8 to
1279680
Compare
mkeeter
force-pushed
the
mkeeter/subcommand-enum
branch
from
7cf583b to
482e78f
Compare
mkeeter
force-pushed
the
mkeeter/lazy-ip-address
branch
2 times, most recently
from
6920a46 to
2b344f4
Compare
mkeeter
force-pushed
the
mkeeter/subcommand-enum
branch
2 times, most recently
from
7c8ea72 to
f92f5e5
Compare
mkeeter
force-pushed
the
mkeeter/lazy-ip-address
branch
2 times, most recently
from
92379ad to
d34127f
Compare
mkeeter
force-pushed
the
mkeeter/subcommand-enum
branch
from
f92f5e5 to
01d62d8
Compare
mkeeter
force-pushed
the
mkeeter/lazy-ip-address
branch
from
d34127f to
387fdb4
Compare
mkeeter
force-pushed
the
mkeeter/subcommand-enum
branch
from
01d62d8 to
4c980ca
Compare
mkeeter
force-pushed
the
mkeeter/lazy-ip-address
branch
from
387fdb4 to
6bfe5b7
Compare
mkeeter
force-pushed
the
mkeeter/subcommand-enum
branch
from
4c980ca to
4665ca1
Compare
mkeeter
force-pushed
the
mkeeter/lazy-ip-address
branch
from
6bfe5b7 to
ad7f519
Compare
mkeeter
force-pushed
the
mkeeter/lazy-ip-address
branch
from
ad7f519 to
8e75f81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Staged on #666)
This PR makes validation of the
--ipargument lazier: we now store aResult<ScopedV6Addr, ScopedV6AddrError>, and only require it to be valid when it's actually used.Fixes #609