[2/n] [reconfigurator] check for stale inventory in mupdate override set path#10409
Merged
sunshowers merged 4 commits intomainfrom May 8, 2026
Conversation
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
jgallagher
approved these changes
May 8, 2026
Contributor
jgallagher
left a comment
jgallagher
left a comment
There was a problem hiding this comment.
Looks great; test is very clear.
sunshowers
changed the base branch from
sunshowers/spr/main.2n-reconfigurator-check-for-stale-inventory-in-mupdate-override-set-path
to
main
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/2n-reconfigurator-check-for-stale-inventory-in-mupdate-override-set-path
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug similar to #10391: a planner running against a stale inventory collection that still shows a mupdate override (because that inventory was captured before the sled cleared the marker) would trigger
BpSetOverrideagain, and undo RFD 556 state machine advancement that that a more recent plan had already completed.The downside of this bug is less severe than #10391, though -- it is limited to zones getting reset to
InstallDatasetand having to set a target release again. So it is an important bug to fix, but (unlike #10391) doesn't need to be cherry-picked onto the release branch.