Skip to content

add Oximeter metrics for NVMe Discard #10419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahrens wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −0
Open

add Oximeter metrics for NVMe Discard #10419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions oximeter/oximeter/schema/virtual-disk.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,33 @@ versions = [
{ added_in = 1, fields = [ "failure_reason" ] }
]

[[metrics]]
name = "bytes_discarded"
description = "Number of bytes discarded from the disk"
units = "bytes"
datum_type = "cumulative_u64"
versions = [
{ added_in = 1, fields = [] }
]

[[metrics]]
name = "discards"
description = "Total number of discard operations to the disk"
units = "count"
datum_type = "cumulative_u64"
versions = [
{ added_in = 1, fields = [] }
]

[[metrics]]
name = "failed_discards"
description = "Total number of failed discard operations to the disk"
units = "count"
datum_type = "cumulative_u64"
versions = [
{ added_in = 1, fields = [ "failure_reason" ] }
]

[[metrics]]
name = "flushes"
description = "Total number of flush operations on the disk"
Expand Down
Loading