Stop activating schemars chrono/uuid1 features in progenitor#1363
Open
jcgruenhage wants to merge 1 commit into
Open
Stop activating schemars chrono/uuid1 features in progenitor#1363jcgruenhage wants to merge 1 commit into
jcgruenhage wants to merge 1 commit into
Conversation
These impls are only needed when consumers derive schemars::JsonSchema on generated types that contain date or uuid fields -- a consumer concern, not progenitor's. example-macro and the README now show the pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These impls are only needed when consumers derive
schemars::JsonSchemaon generated types that containdateoruuidfields -- a consumer concern, not progenitor's.example-macroand theREADMEnow show the pattern.Resolves #1362