Skip to content

refactor: call info once at the end of index writing#402

Draft
dkharms wants to merge 1 commit into336-blockbuilderfrom
336-offsets-no-ids
Draft

refactor: call info once at the end of index writing#402
dkharms wants to merge 1 commit into336-blockbuilderfrom
336-offsets-no-ids

Conversation

@dkharms
Copy link
Copy Markdown
Member

@dkharms dkharms commented Apr 10, 2026

Description

When we were building .index file for some reason we wanted to stored total amount of seq.ID (including seq.SystemID) in section of DocBlock offsets.

For sealing from Active fraction this is not a problem since we already have all necessary numbers in memory, but for compaction it is -- we do not know in advance total count of ids.

And, in my opinion, it is not correct to rely on Info while building index -- we can fully construct info only after index building.


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant