perf: implement batch processing in iterateEvalTree#406
Open
cheb0 wants to merge 3 commits into329-batching-1from
Open
perf: implement batch processing in iterateEvalTree#406cheb0 wants to merge 3 commits into329-batching-1from
cheb0 wants to merge 3 commits into329-batching-1from
Conversation
Collaborator
Author
|
@seqbenchbot up main search-keyword-exact-match-warm |
Collaborator
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 329-batching-1 #406 +/- ##
==================================================
- Coverage 71.54% 70.58% -0.97%
==================================================
Files 220 221 +1
Lines 16568 20423 +3855
==================================================
+ Hits 11854 14415 +2561
- Misses 3840 5128 +1288
- Partials 874 880 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@seqbenchbot down e8eefca9 |
Collaborator
|
Nice, @cheb0 The benchmark with identificator Show summary
Have a great time! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #390
iterateEvalTreeworks with batches of lids, requests batches of mids and ridsget_midstepI did some measurements for both patches (this combined with #390) vs main (used bitpack encoding in both branches). For small ordinary searches there is no benefit. For dense analytic queries there is a decent improvement.
For our k6 benchmark
seq-db-hist.js:2.3 sec=>650 msFor
seq-db-aggs.js:6.1 sec=>4.7 secHist over
_all_(warm query) (3 prod fractions):~37 ms=>~15 msPart of #329