Skip to content

Make entire tab area clickable, not just the icon#132

Merged
pablopunk merged 1 commit intomainfrom
fix/clickable-tabs
Apr 9, 2026
Merged

Make entire tab area clickable, not just the icon#132
pablopunk merged 1 commit intomainfrom
fix/clickable-tabs

Conversation

@pablopunk
Copy link
Copy Markdown
Owner

@pablopunk pablopunk commented Apr 9, 2026

Adds .contentShape(Rectangle()) so the full tab button area is clickable, matching the mousetrap implementation.

Summary by CodeRabbit

  • Bug Fixes
    • Improved tab button click responsiveness by expanding the interactive hit area to the entire button surface for more reliable tapping and clicking.

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Apr 9, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 9, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f0773bf3-d885-44f6-a543-5d9e5d9b6ceb

📥 Commits

Reviewing files that changed from the base of the PR and between 6eb5cad and d7d924a.

📒 Files selected for processing (1)
  • Swift Shift/src/View/AppView.swift

Walkthrough

A .contentShape(Rectangle()) modifier was added to each tab button's label in the AppView to define the hit-testing shape for the tappable area as a full rectangle. This change affects how user taps are detected on tab buttons without altering the view hierarchy, selection logic, or overall control flow.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pablopunk pablopunk merged commit 08692ff into main Apr 9, 2026
3 of 4 checks passed
@pablopunk pablopunk deleted the fix/clickable-tabs branch April 9, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant