wip: Instrument calls to refresh the cached timeline#494
Open
nikclayton wants to merge 6 commits intomainfrom
Open
wip: Instrument calls to refresh the cached timeline#494nikclayton wants to merge 6 commits intomainfrom
nikclayton wants to merge 6 commits intomainfrom
Conversation
A user report shows what appears to be spurious / unexpected calls to refresh the cached timeline occuring while scrolling. Have confirmed these calls aren't coming from any Pachli code, so adding additional instrumentation that can be included in a custom APK to debug further.
Contributor
Author
|
/apk |
|
Workflow Build and sign APK for PR: succeeded ✅ |
….1.4 (#385) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.github.oshai:kotlin-logging-jvm](https://togithub.com/oshai/kotlin-logging) | `5.1.0` -> `5.1.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>oshai/kotlin-logging (io.github.oshai:kotlin-logging-jvm)</summary> ### [`v5.1.4`](https://togithub.com/oshai/kotlin-logging/releases/tag/5.1.4) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/5.1.1...5.1.4) #### What's Changed - fix - protect from uncontrolled format string by [@​oshai](https://togithub.com/oshai) in [https://github.com/oshai/kotlin-logging/pull/381](https://togithub.com/oshai/kotlin-logging/pull/381) **Full Changelog**: oshai/kotlin-logging@5.1.1...5.1.4 ### [`v5.1.1`](https://togithub.com/oshai/kotlin-logging/releases/tag/5.1.1) [Compare Source](https://togithub.com/oshai/kotlin-logging/compare/5.1.0...5.1.1) #### What's Changed - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/357](https://togithub.com/oshai/kotlin-logging/pull/357) - Bump actions/cache from 3.3.1 to 3.3.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/358](https://togithub.com/oshai/kotlin-logging/pull/358) - Bump com.diffplug.spotless from 6.20.0 to 6.22.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/oshai/kotlin-logging/pull/362](https://togithub.com/oshai/kotlin-logging/pull/362) - add payload to LocationAwareKLogger by [@​oshai](https://togithub.com/oshai) in [https://github.com/oshai/kotlin-logging/pull/332](https://togithub.com/oshai/kotlin-logging/pull/332) **Full Changelog**: oshai/kotlin-logging@5.1.0...5.1.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/pachli/pachli-android). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Contributor
Author
|
/apk |
|
Workflow Build and sign APK for PR: succeeded ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user report shows what appears to be spurious / unexpected calls to refresh the cached timeline occuring while scrolling. Have confirmed these calls aren't coming from any Pachli code, so adding additional instrumentation that can be included in a custom APK to debug further.