feat: enable logging of github request ID - #601
Merged
bulldozer-bot[bot] merged 1 commit intoAug 11, 2026
Merged
Conversation
Generate changelog in
|
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 📋Changelog Preview💡 Improvements
|
asvoboda
approved these changes
Aug 11, 2026
| Int("status", res.StatusCode) | ||
| if requestID := res.Header.Get(httpHeaderRequestID); requestID != "" { | ||
| evt.Str("github_request_id", requestID) | ||
| } |
Member
There was a problem hiding this comment.
I think its probably friendly to always log this, but that being said similar to logging the rate limit info we may want to gate this info in an option to allow users who are sensitive to log volume to opt in or out. I'm happy to merge as is though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Structured
github_requestlogs do not include GitHub’s request ID, making it more difficult to diagnose failures involving the GitHub API.After this PR
==COMMIT_MSG==
GitHub request IDs are now included in GitHub client logs.
==COMMIT_MSG==
Possible downsides?
More verbose logs?
This PR originated out of this discussion.