Add support for blockdiag actdiag nwdiag packetdiag rackdiag seqdiag#12
Open
priiduonu wants to merge 1 commit into
Open
Add support for blockdiag actdiag nwdiag packetdiag rackdiag seqdiag#12priiduonu wants to merge 1 commit into
priiduonu wants to merge 1 commit into
Conversation
Member
|
Thank you for the PR, and apologies for the late reply, I had to let my open source involvement rest for a while. I'm still a bit on the fence about this PR. My rule-of-thumb on what code to include here is whether I'd be willing to maintain the code myself, and I'm not sure in this case. My preferred solution would be to have this in a separate repository, with instructions on how to use it as an engine via the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.