spike(world-map): OpenFreeMap vector dark basemap (#7077) — parked#7150
Draft
wcjord wants to merge 1 commit into
Draft
spike(world-map): OpenFreeMap vector dark basemap (#7077) — parked#7150wcjord wants to merge 1 commit into
wcjord wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parked spike for #7077 (dark-map contrast + water). NOT for merge yet — punting on the vector approach for now; this branch preserves the working integration so it can be picked up later.
What this does
Replaces the dark basemap (CartoDB Dark Matter raster) with OpenFreeMap VECTOR tiles, styled client-side, so label contrast + water are ours with a single request. Light mode stays OSM raster. The CartoDB raster is kept as an automatic fallback while the vector style loads / if it errors.
pubspec.yaml:vector_map_tiles: 9.0.0-beta.9(pinned exact — only the 9.x prerelease is compatible with ourflutter_map ^8.2.2; stable 8.x needs flutter_map 7, and 10.x needs Flutter main + Impeller).world_map.dart:WorldMapController.darkMapStyleloads the OpenFreeMap dark style once.world_map_view.dart: dark base layer is aFutureBuilder<Style>→VectorTileLayer(default rasterlayerModeso each tile is rasterized once + blitted), raster fallback otherwise; attribution updated to OpenMapTiles.What's confirmed
flutter_map/flutter_map_marker_cluster8.2.2 and compiles for Flutter web (the key unknown).Why it's parked
9.0.0-beta.9).To resume
The integration is complete; the open problem is web rendering cost. Options to revisit: self-host OpenFreeMap tiles, tune the vector layer (concurrency / raster mode / tile delay), restyle the OpenFreeMap dark style (water + label colors — it ships "not yet complete"), handle the
ne2_shadedraster relief source, and benchmark against real device analytics before flipping it on. Or fall back to the Stadia raster stopgap if a quicker contrast/water win is wanted.