Skip to content

Span title remove height limit and scrolling#7713

Merged
wcjord merged 2 commits into
mainfrom
span-title
Jul 18, 2026
Merged

Span title remove height limit and scrolling#7713
wcjord merged 2 commits into
mainfrom
span-title

Conversation

@Kelrap

@Kelrap Kelrap commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Thank you so much for your contribution to FluffyChat ❤️❤️❤️

Pull Request has been tested on:

  • Android
  • iOS
  • Browser (Chromium based)
  • Browser (Firefox based)
  • Browser (WebKit based)
  • Desktop Linux
  • Desktop Windows
  • Desktop macOS

Accessibility

  • New or changed controls have an accessible name (tooltip: / semanticLabel:), and decorative images use excludeFromSemantics: true. See accessibility.instructions.md. (The source-level gate enforces this; manual a11y review is owned by whoever changes the UI.)

Summary by CodeRabbit

  • Style

    • Simplified the popup header layout for a cleaner, more consistent title and action-button presentation.
    • Improved formatting across course-list and panel interfaces without changing functionality.
  • Tests

    • Added coverage for text splitting around emoji to help preserve correct character boundaries.
    • Maintained coverage for grammar practice, room access errors, and conversation suggestions.

@Kelrap Kelrap linked an issue Jul 16, 2026 that may be closed by this pull request
1 task
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f8e134b0-1871-423d-a48c-672409b7589f

📥 Commits

Reviewing files that changed from the base of the PR and between 23bb92e and 5ec7e47.

📒 Files selected for processing (5)
  • lib/routes/chat/choreographer/igc/span_card.dart
  • lib/routes/world/left_panel/left_panel_courses_list_view.dart
  • test/pangea/grammar_error_example_split_test.dart
  • test/pangea/knock_space_response_test.dart
  • test/pangea/orchestrator_controller_suggestion_test.dart

📝 Walkthrough

Walkthrough

The PR simplifies the span card popup header layout, reformats course panel expressions, adds emoji grapheme-boundary coverage to grammar tests, and reformats two existing tests without changing their assertions.

Changes

Popup header layout

Layer / File(s) Summary
Span card header row
lib/routes/chat/choreographer/igc/span_card.dart
Replaces the scrollable fixed-height title container with a direct row containing the close button, centered title, and feedback button.

Course panel formatting

Layer / File(s) Summary
Course panel layout expressions
lib/routes/world/left_panel/left_panel_courses_list_view.dart
Reformats the course filter, header condition, and empty-state dividers without changing behavior.

Test updates

Layer / File(s) Summary
Grammar and response test updates
test/pangea/grammar_error_example_split_test.dart, test/pangea/knock_space_response_test.dart, test/pangea/orchestrator_controller_suggestion_test.dart
Adds emoji grapheme-alignment coverage and reformats existing test declarations and calls.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: wcjord

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing the span title height limit and scrolling.
Description check ✅ Passed The description matches the repository template and includes the required contributing, testing, and accessibility sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch span-title

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@wcjord
wcjord merged commit d8ef9b1 into main Jul 18, 2026
6 checks passed
@wcjord
wcjord deleted the span-title branch July 18, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Writing assistance title cut off

2 participants