-
Notifications
You must be signed in to change notification settings - Fork 27
Add Windows executable builds to the CI workflow. #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
coco-314
wants to merge
31
commits into
panglesd:main
Choose a base branch
from
coco-314:feature/ci-add-windows-exe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
716b9e0
Add Windows executable builds to the CI workflow.
coco-314 fb1dd7f
Using version 3 of action "setup-ocaml"
coco-314 155a79c
Removing cf deps to check if it allows installing deps on Windows
panglesd 0028f01
Windows: Check if preprocessing is not working on Windows
panglesd 0c7faa4
Test ci on windows
panglesd 6a0e50d
More windows tests
panglesd 226ef3f
backslashes not as escapes
panglesd bee2215
Changes to path separator handling for the various target OS of the CI
coco-314 22faaad
Fixes the creation of a folder in the CI Windows job
coco-314 67ec52c
For debug
coco-314 cb093ac
New try
coco-314 aed85ed
Windows distribution via a ZIP file
coco-314 f40b490
Using native PowerShell to create the ZIP archive
coco-314 7a7bf33
Test to see what is responsible for the windows CI problem
panglesd b1f52bf
Windows CI: Only install x86_64 packages
panglesd dd78b12
Test
panglesd f01e576
Debugging
coco-314 02d6010
fix debug
coco-314 0a2b1eb
dune install
coco-314 9e4192a
CI: Add a cache to windows CI
panglesd d12df1e
Copy missing dlls inti bundle
coco-314 5e2ccf2
Instal opensll and zlib
coco-314 d9734d6
Fix Build installable artifacts
coco-314 9393f67
Test ntldd
coco-314 94b3fb8
Copy dlls
coco-314 e11736f
Copy dlls
coco-314 98303a0
Try installer Oui
coco-314 e9cc780
Try Wix installation witrh dotnet
coco-314 61bbca2
Fix oui installation
coco-314 a5fd3a9
Use WIX
coco-314 7f1d3a6
Comment version getter
coco-314 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is probably that v2 is an old version that used to go through hoops to work on windows, and the hoops have been removed. While the version 3 uses the now better Windows support from opam.