Wire animated block rendering#1
Open
newmattock wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses OpenSword#1
References OpenSword#3
Completes the remaining animation hookup and cleanup slice discussed in OpenSword#1 and OpenSword#3.
Changes:
IsometricRendererto useBlockType.get_current_frame(animation_time)so animated block types actually advance frames whenanimatedandanimation_framesare configured._process()without redrawing the whole world.InteractionModeenum and no longer describe a nonexistentQUERYmode.Validation:
git diff --checkrg -n "QUERY|_create_colored_texture" scripts docsreturns no matchesgodot --version->4.6.2.stable.official.71f334935godot --headless --path . --importgodot --headless --path . --scene res://scenes/Main.tscn --quit-after 180godot --path . --scene res://scenes/Main.tscn --write-movie /tmp/openisopix-demo.avi --quit-after 180godot --path . --scene res://scenes/Main.tscn --write-movie /tmp/openisopix-frames/frame.png --fixed-fps 30 --quit-after 60Local demo evidence:
643e9af3851abb0ed507bb34a9153e9eac96c046.6071dfa10937b4f9a2b5c555f72724bd791e17b2.c04c718e7ea533cc9d7d674416c8f084541963f5andcb86b0b945bc1dbb1b0653ca6b8c4b8bd02ab977, matching the configured water animation frames.