Add proper memo_wise initialization for inherited classes#392
Conversation
82a3cd9 to
74c4b42
Compare
|
|
||
| Results using Ruby 3.4.3: | ||
|
|
||
| |Method arguments|`alt_memery` (2.1.0)|`dry-core`\* (1.1.0)|`memery` (1.7.0)|`memoist3` (1.0.0)|`short_circu_it` (0.29.3)| |
There was a problem hiding this comment.
| Method arguments | memo_wise-github-main (1.13.0) |
|---|---|
() (none) |
1.00x |
(a) |
1.00x |
(a, b) |
0.98x |
(a:) |
0.99x |
(a:, b:) |
1.01x |
(a, b:) |
1.00x |
(a, *args) |
1.05x |
(a:, **kwargs) |
0.97x |
(a, *args, b:, **kwargs) |
1.00x |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 197 200 +3
Branches 89 89
=========================================
+ Hits 197 200 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the PR, @Galathius ! I'm not sure this is right, though—your tests pass even when I remove the Edit: I actually don't understand the issue you're encountering; see #382 (comment) |
74c4b42 to
c20455c
Compare
|
Hi @JacobEvelyn! Sorry, seems I accidentally removed Just updated it, now if you comment my code in |
Hopefully it solves the issue from this comment.
This change should allow such usage:
Now it's failing with:
Before merging:
README.mdand update this PRCHANGELOG.md, add an entry following Keep a Changelog guidelines with semantic versioning