Skip to content

Add XML tags and block quote syntax test cases - #42

Draft
ericelliott with Copilot wants to merge 2 commits into
mainfrom
copilot/add-xml-tags-support
Draft

Add XML tags and block quote syntax test cases#42
ericelliott with Copilot wants to merge 2 commits into
mainfrom
copilot/add-xml-tags-support

Conversation

Copilot AI commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown

This PR adds comprehensive test cases to syntax-test.sudo for XML tag and block quote syntax highlighting support as requested in #[issue_number].

Test Cases Added

XML Tags

Added test examples demonstrating XML tags with embedded code blocks:

<template>
```ts
console.log('Hello, world!');
function myFunction() {
  console.log('Hello, world!');
}
```

The test cases include:

  • <template> tags with TypeScript code blocks
  • <template-t> tags with TypeScript code blocks (multiple instances)
  • <my-tag attr="value"> tags with attributes

These examples will help validate syntax highlighting for XML-style tags similar to how they appear in markdown files, where tags, attributes, and embedded code blocks should each receive appropriate syntax coloring.

Block Quotes

Added test example for triple-quote block quote syntax:

"""
An example block quote.
"""

Notes

These test cases follow the existing conventions in syntax-test.sudo and provide a foundation for implementing proper syntax highlighting for XML tags and block quotes in SudoLang files. The actual syntax highlighting implementation will be addressed in a follow-up change.

Original prompt

This section details on the original issue you should resolve

<issue_title>[VSCode] XML tags support</issue_title>
<issue_description>## Current highlighting with sudolang
Image

Current highlighting with md files

Image

Extra notes

Also, if you could make it so that all of these highlight well, that would be awesome:

Image

Test code is:

<template>
\`\`\`ts
console.log('Hello, world!');
function myFunction() {
  console.log('Hello, world!');
}
\`\`\`
</template>
<template-t>
\`\`\`ts
console.log('Hello, world!');
function myFunction() {
  console.log('Hello, world!');
}
\`\`\`
</template-t>

<template-t>
\`\`\`ts
console.log('Hello, world!');
function myFunction() {
  console.log('Hello, world!');
}
\`\`\`
</template-t>
```</issue_description>

<agent_instructions>Copilot, please use the conventions in `syntax-test.sudo` to add these syntax highlighting examples. Don't fix the syntax highlighting yet, just add the tests.

Please also add:

"""
An example block quote.
"""


## Comments on the Issue (you are @copilot in this section)

<comments>
<comment_new><author>@ericelliott</author><body>
Copilot, please use the conventions in `syntax-test.sudo` to add these syntax highlighting examples. Don't fix the syntax highlighting yet, just add the tests.

Please also add:

"""
An example block quote.
"""

</comments>

Fixes #39

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@ericelliott
Add XML tags and block quote test cases to syntax-test.sudo
cfada72 
Co-authored-by: ericelliott <364727+ericelliott@users.noreply.github.com>
Copilot AI changed the title [WIP] Add XML tags support for improved highlighting Add XML tags and block quote syntax test cases Oct 17, 2025
Copilot AI requested a review from ericelliott October 17, 2025 00:19
@ericelliott

ericelliott commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

@cursor 🙏 review

@cursor

cursor Bot commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown

PR Review Summary ✅

I've reviewed the changes and the PR looks excellent! Here's my assessment:

✅ Approved - All Requirements Met

What's been added:

  • XML Tags section with comprehensive test cases:

    • <template> tags with embedded TypeScript code blocks
    • <template-t> tags (multiple instances as requested)
    • <my-tag attr="value"> demonstrating attributes
    • All examples include properly formatted code blocks with triple backticks

  • Block Quotes section with:

    • Triple-quote syntax example (""")
    • Clear description of the feature

Quality checks:
✅ Follows existing file conventions (section headers, descriptions, examples)
✅ All requested test cases from the issue are present
✅ Proper formatting and spacing consistent with the rest of the file
✅ Placed logically before the "Disallowed Keywords" section
✅ No syntax highlighting implementation (as instructed - tests only)
✅ Clear, descriptive section headers and explanatory text

No issues found. The PR successfully adds the test infrastructure needed for implementing XML tag and block quote syntax highlighting in a future change. Ready to merge! 🚀

Open in Cursor Open in Web

Learn more about Cursor Agents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericelliott ericelliott Awaiting requested review from ericelliott

Assignees

@ericelliott ericelliott

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[VSCode] XML tags support

2 participants

@ericelliott