fix(server): install timer for HTTP/2 connections - #1644
Open
mindrunner wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TokioTimeron the server HTTP/2 builder used by accepted connections.TokioTimeron the low-levelserveandserve_with_graceful_shutdownhelpers.Context
Hyper 1.x requires an explicit timer for HTTP/2 keep-alive / timeout handling. jsonrpsee exposes server keep-alive configuration via
ServerConfigBuilder::set_keep_alive, but the underlyinghyper_util::server::conn::auto::Builderis currently created with onlyTokioExecutor.That means a server configured with HTTP/2 keep-alive can panic at runtime when an HTTP/2 connection constructs hyper's ping channel:
You must supply a timer.This mirrors the timer setup tonic added for its hyper-backed server path.