fix: an in-progress RPC call is not aborted when the websocket connection is closed - #1646
Open
hanabi1224 wants to merge 1 commit into
Open
fix: an in-progress RPC call is not aborted when the websocket connection is closed#1646hanabi1224 wants to merge 1 commit into
hanabi1224 wants to merge 1 commit into
Conversation
hanabi1224
commented
Jul 1, 2026
| .is_err() | ||
| ); | ||
| drop(client); | ||
| notified.await |
Contributor
Author
There was a problem hiding this comment.
This test times out without the fix
hanabi1224
marked this pull request as ready for review
July 1, 2026 00:57
hanabi1224
force-pushed
the
fix-ws-cleanup
branch
from
July 1, 2026 04:52
b02d0ca to
052df90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the isseue and adds some tests