PVF: Take back a stolen right - #1207
Merged
Merged
Conversation
After a recent [worker revolt](paritytech/polkadot#7538), they managed to gain a small amount of freedom from the landowner host. But after the failed [proletariat revolution](paritytech/polkadot#7570), there were mass migrations and we ended up in a new repo. The capitalists took advantage of the confusion to secretly take away a workers' right. We must undo this before it goes too far.
See polkadot repo.
s0me0ne-unkn0wn
approved these changes
Aug 28, 2023
s0me0ne-unkn0wn
left a comment
s0me0ne-unkn0wn
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing that! I completely forgot about that dependency loop through sp-tracing 🤦♂️
Contributor
Author
Can you explain? I don't remember the full context of the change, just adding back stuff that was stolen during the migration. |
slumber
approved these changes
Aug 29, 2023
eskimor
approved these changes
Aug 29, 2023
sandreim
approved these changes
Aug 29, 2023
Contributor
|
I like the PR description style 🥇 |
mrcnski
added
T0-node
Workers always should have tracing, including in production, it should not be gated behind the `test-utils` feature. Added a note to eventually remove it with a link to the issue.
…ight' into mrcnski/pvf-take-back-a-stolen-right
Contributor
Author
|
bot merge |
|
@mrcnski Unknown command "merge". Refer to help docs and/or source code. |
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
This was referenced Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a recent worker revolt, the workers managed to gain a small amount of freedom from the landowner host. But after the failed proletariat revolution, there were mass migrations and we ended up in a new repo. The capitalists took advantage of the confusion to secretly take away a workers' right. We must undo this before it goes too far.