refactor: Bump basic-ftp from 5.2.0 to 5.2.2#3334
refactor: Bump basic-ftp from 5.2.0 to 5.2.2#3334dependabot[bot] wants to merge 1 commit intoalphafrom
Conversation
dependabot
Bot
added
dependencies
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
Bot
changed the title
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/basic-ftp-5.2.2
branch
2 times, most recently
from
e3e408d to
88f13a3
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughUpdated the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@dependabot rebase |
|
Looks like this PR is already up-to-date with alpha! If you'd still like to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package-lock.json`:
- Around line 12581-12583: The lockfile shows basic-ftp@5.3.0 but the commit
88f13a3 and Dependabot metadata target 5.2.2; decide whether to accept 5.3.0 or
restore 5.2.2, then update package-lock.json accordingly: if accepting 5.3.0,
update the Dependabot/commit message and regenerate package-lock.json (run npm
install, commit the new lockfile) and update any Dependabot config referencing
basic-ftp/get-uri; if pinning 5.2.2, add an explicit resolution/override for
basic-ftp (or update get-uri constraint), restore the lockfile to include
basic-ftp@5.2.2 by running npm install/npm ci against the corrected
package.json, and commit the regenerated package-lock.json so the lockfile and
the stated intent (5.2.2) match.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| "version": "5.3.0", | ||
| "resolved": "https://registry.npmjs.org/basic-ftp/-/basic-ftp-5.3.0.tgz", | ||
| "integrity": "sha512-5K9eNNn7ywHPsYnFwjKgYH8Hf8B5emh7JKcPaVjjrMJFQQwGpwowEnZNEtHs7DfR7hCZsmaK3VA4HUK0YarT+w==", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Manifest/lock versions for basic-ftp =="
fd -i 'package.json|package-lock.json' | while read -r f; do
echo "--- $f"
rg -n '"basic-ftp"|node_modules/basic-ftp|"version": "5\.' "$f" -n -C2 || true
done
echo
echo "== npm registry metadata for 5.2.2 and 5.3.0 =="
curl -s https://registry.npmjs.org/basic-ftp \
| jq -r '
.versions["5.2.2"] as $v522
| .versions["5.3.0"] as $v530
| "5.2.2 dist.tarball=\($v522.dist.tarball)\n5.2.2 dist.integrity=\($v522.dist.integrity)\n5.3.0 dist.tarball=\($v530.dist.tarball)\n5.3.0 dist.integrity=\($v530.dist.integrity)"
'
echo
echo "== Check package scripts in published tarballs (read-only inspect) =="
tmpdir="$(mktemp -d)"
for v in 5.2.2 5.3.0; do
url=$(curl -s https://registry.npmjs.org/basic-ftp/$v | jq -r '.dist.tarball')
curl -sL "$url" -o "$tmpdir/basic-ftp-$v.tgz"
echo "--- basic-ftp@$v scripts"
tar -xOf "$tmpdir/basic-ftp-$v.tgz" package/package.json | jq '.scripts // {}'
doneRepository: parse-community/parse-dashboard
Length of output: 50387
🏁 Script executed:
cat -n package.json | grep -A2 -B2 "basic-ftp"Repository: parse-community/parse-dashboard
Length of output: 57
🏁 Script executed:
#!/bin/bash
echo "=== Checking basic-ftp versions 5.2.2 vs 5.3.0 in npm registry ==="
curl -s https://registry.npmjs.org/basic-ftp/5.2.2 | jq -r '.version, .dist.tarball, (.dist.integrity // "N/A")'
echo ""
echo "---"
echo ""
curl -s https://registry.npmjs.org/basic-ftp/5.3.0 | jq -r '.version, .dist.tarball, (.dist.integrity // "N/A")'Repository: parse-community/parse-dashboard
Length of output: 469
🏁 Script executed:
#!/bin/bash
# Search for basic-ftp in package.json more carefully
echo "=== Searching for basic-ftp in package.json ==="
grep "basic-ftp" package.json
echo ""
echo "=== Checking if there are any .git or PR metadata files ==="
ls -la | grep -E "\.git|pr|PR|changelog|CHANGELOG"
echo ""
echo "=== Searching for basic-ftp anywhere in the repo (excluding node_modules and lock) ==="
rg "basic-ftp" --type-list | head -20
rg "basic-ftp" -g "!node_modules" -g "!package-lock.json" | head -30Repository: parse-community/parse-dashboard
Length of output: 2980
🏁 Script executed:
#!/bin/bash
# Search for which dependency requires basic-ftp
echo "=== Direct dependencies in package.json ==="
cat package.json | jq -r '.dependencies | keys[]'
echo ""
echo "=== Dev dependencies in package.json ==="
cat package.json | jq -r '.devDependencies | keys[]'
echo ""
echo "=== Searching for which package depends on basic-ftp ==="
rg '"basic-ftp"' -A1 -B5 | head -50Repository: parse-community/parse-dashboard
Length of output: 1937
🏁 Script executed:
#!/bin/bash
# Check which package in node_modules requires basic-ftp
echo "=== Which top-level package depends on basic-ftp? ==="
rg '"basic-ftp"' -B10 package-lock.json | grep -E 'node_modules/[^/]+.*:|"basic-ftp"' | head -20
echo ""
echo "=== Check git log for commits mentioning basic-ftp or version 5.2.2 ==="
git log --oneline --all -20 | head -20
echo ""
echo "=== Check for any commit messages mentioning basic-ftp ==="
git log --all --grep="basic-ftp" --grep="5.2.2" --oneline || echo "No commits found with those keywords"
echo ""
echo "=== Check the most recent changes to package-lock.json ==="
git log --oneline -5 -- package-lock.json
echo ""
echo "=== Show what changed in package-lock.json recently (basic-ftp section) ==="
git show HEAD:package-lock.json | rg -A3 -B3 'node_modules/basic-ftp' | head -20Repository: parse-community/parse-dashboard
Length of output: 2461
🏁 Script executed:
#!/bin/bash
# Show the specific commit that was supposed to bump to 5.2.2
echo "=== Show the diff for the 5.2.2 bump commit ==="
git show 88f13a3 -- package-lock.json | grep -A5 -B5 '"basic-ftp"' | head -40
echo ""
echo "=== Check if there's a more recent commit after 88f13a3 that changed basic-ftp ==="
git log --oneline --all -- package-lock.json | head -10
echo ""
echo "=== Show commits between 88f13a3 and HEAD that touched package-lock.json ==="
git log 88f13a3..HEAD --oneline -- package-lock.jsonRepository: parse-community/parse-dashboard
Length of output: 1224
🏁 Script executed:
#!/bin/bash
# Check what the actual version of basic-ftp was in commit 88f13a3
echo "=== Actual basic-ftp version in commit 88f13a3 ==="
git show 88f13a3:package-lock.json | rg -A3 '"node_modules/basic-ftp"'
echo ""
echo "=== Current basic-ftp version (HEAD) ==="
git show HEAD:package-lock.json | rg -A3 '"node_modules/basic-ftp"'
echo ""
echo "=== Check if npm install would auto-update to 5.3.0 based on get-uri's range ==="
echo "get-uri dependency: basic-ftp ^5.0.2 allows any version >= 5.0.2 and < 6.0.0"
echo ""
echo "=== Latest published versions of basic-ftp on npm ==="
curl -s https://registry.npmjs.org/basic-ftp | jq -r '.versions | keys[-5:]'Repository: parse-community/parse-dashboard
Length of output: 951
🏁 Script executed:
#!/bin/bash
# Verify: show the exact diff for commit 88f13a3
echo "=== Full diff for commit 88f13a3 focusing on basic-ftp lines ==="
git diff 88f13a3^..88f13a3 -- package-lock.json | grep -A10 -B10 "basic-ftp" | head -60
echo ""
echo "=== Check what version 88f13a3 claims to bump FROM ==="
git show 88f13a3^:package-lock.json | rg -A2 '"node_modules/basic-ftp"' 2>/dev/null || echo "No basic-ftp found in parent"Repository: parse-community/parse-dashboard
Length of output: 320
🏁 Script executed:
#!/bin/bash
# Check the commit message directly
echo "=== Commit message for 88f13a3 ==="
git log -1 --format="%B" 88f13a3
echo ""
echo "=== Check if there's a PR description or related issue ==="
git log --all --grep="5.2.2" --format="%H %s" | head -10
echo ""
echo "=== Verify: did npm lock file get regenerated after the commit? ==="
echo "Checking if package-lock.json timestamp differs from commit 88f13a3..."
git log --format="%H %ai" 88f13a3 | head -1
echo ""
echo "=== See all commits that touched basic-ftp in the log ==="
git log --all --oneline | grep -i "basic-ftp"Repository: parse-community/parse-dashboard
Length of output: 1864
Lockfile version (5.3.0) does not match committed intent (5.2.2).
Commit 88f13a3 is titled "refactor: bump basic-ftp from 5.2.0 to 5.2.2" and includes Dependabot metadata explicitly targeting version 5.2.2, but the package-lock.json at that commit and currently at HEAD contains version 5.3.0. The mismatch likely occurred because basic-ftp is an indirect dependency (via get-uri with constraint ^5.0.2), which permits version 5.3.0. Either the lockfile was regenerated after the commit with npm install without pinning to the intended version, or the upgrade scope was widened intentionally. Clarify whether 5.3.0 is acceptable or if the lock should be regenerated to match the stated 5.2.2 target.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@package-lock.json` around lines 12581 - 12583, The lockfile shows
basic-ftp@5.3.0 but the commit 88f13a3 and Dependabot metadata target 5.2.2;
decide whether to accept 5.3.0 or restore 5.2.2, then update package-lock.json
accordingly: if accepting 5.3.0, update the Dependabot/commit message and
regenerate package-lock.json (run npm install, commit the new lockfile) and
update any Dependabot config referencing basic-ftp/get-uri; if pinning 5.2.2,
add an explicit resolution/override for basic-ftp (or update get-uri
constraint), restore the lockfile to include basic-ftp@5.2.2 by running npm
install/npm ci against the corrected package.json, and commit the regenerated
package-lock.json so the lockfile and the stated intent (5.2.2) match.
Bumps [basic-ftp](https://github.com/patrickjuchli/basic-ftp) from 5.2.0 to 5.2.2. - [Release notes](https://github.com/patrickjuchli/basic-ftp/releases) - [Changelog](https://github.com/patrickjuchli/basic-ftp/blob/master/CHANGELOG.md) - [Commits](patrickjuchli/basic-ftp@v5.2.0...v5.2.2) --- updated-dependencies: - dependency-name: basic-ftp dependency-version: 5.2.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/basic-ftp-5.2.2
branch
from
88f13a3 to
3c42450
Compare
|
Closing: Dependabot's lock file update incorrectly removes |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
1 participant
Bumps basic-ftp from 5.2.0 to 5.2.2.
Release notes
Sourced from basic-ftp's releases.
Changelog
Sourced from basic-ftp's changelog.
Commits
e9d09d6Bump version20327d3Move prevention of control character injection to more central placeba40f9dUpdate dev dependencies6b0008bBump version2ecc8e2Reject control character injection attempts using paths515d21fUpdate security policy and reporting instructions9744254Link to security advisoryMaintainer changes
This version was pushed to npm by patrickjuchli, a new releaser for basic-ftp since your current version.
Install script changes
This version adds
preparescript that runs during installation. Review the package contents before updating.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by CodeRabbit