[boron|bsom] u-blox R510 FOTA over HTTPS support#2358
Open
technobly wants to merge 1 commit into
Open
Conversation
c960d0c to
6afbd81
Compare
545fa28 to
8d591c0
Compare
8d591c0 to
89d39b8
Compare
89d39b8 to
0e2f5db
Compare
avtolstoy
requested changes
Oct 12, 2021
avtolstoy
left a comment
Member
There was a problem hiding this comment.
There is quite a lot of complexity here and since things are not that tightly coupled to NCP client or other subsystems, it would be really nice to see unit tests for this. cellular_command(), callbacks, system methods and other dependent functions can easily be mocked and we can validate all the steps under various conditions.
Member
Author
|
For the moment I have reverted renaming the files to make viewing changes easier. This is a TODO for me to go back and rename ncp_fw_update.cpp/.h to sara_ncp_fw_update.cpp/.h |
3c678a4 to
33ff8bf
Compare
16a5c06 to
ae61beb
Compare
02d203d to
e36500c
Compare
6b634a8 to
9d4d141
Compare
9d4d141 to
1296304
Compare
1296304 to
faf307c
Compare
faf307c to
8f4a7c8
Compare
c761976 to
5526632
Compare
e1df053 to
8646a46
Compare
8646a46 to
d611b47
Compare
d611b47 to
a1a35cf
Compare
…re/SARA-R510-NCP-FW-update)
Author: Technobly <technobly@gmail.com>
Date: Wed Dec 15 16:26:50 2021 -0600
reduce specificity of expected publishEvent calls
commit c9d846b
Author: Technobly <technobly@gmail.com>
Date: Wed Dec 15 13:24:25 2021 -0600
update CI unit tests to output verbose logs on failure
commit 62c8fd9
Author: Technobly <technobly@gmail.com>
Date: Tue Dec 14 13:17:39 2021 -0600
addresses final PR comments
- Adds SaraNcpFwUpdateLock to make user interfaces thread-safe
- Fixes issue with sUrcHandlers not retaining unique pointers
- Allows cellular disconnect timeouts to proceed
- Adds cellular_lock() before accessing variables used in urcHandlers
- Fixes errors with comm. unit_tests caused by some initial code added for ncp_fw_update testing
- Moves all NCPFW_LOG statements during SAFE_MODE to NCPFW_LOG_DEBUG to reduce size
commit b509fbf
Author: Technobly <technobly@gmail.com>
Date: Fri Dec 10 22:42:52 2021 -0600
adds system_errors and diagnostics
commit ac13d10
Author: Technobly <technobly@gmail.com>
Date: Tue Nov 30 23:20:27 2021 -0600
adds SaraNcpFwUpdate unit tests
commit 41f4093
Author: Technobly <technobly@gmail.com>
Date: Mon Nov 22 23:19:58 2021 -0600
[hal] cellular add/remove urc handler
commit 7c0d8f9
Author: Technobly <technobly@gmail.com>
Date: Mon Nov 15 12:21:38 2021 -0600
skeleton for SaraNcpFwUpdate unit tests
commit 5bb6334
Author: Technobly <technobly@gmail.com>
Date: Fri Oct 29 20:59:23 2021 -0500
addresses most PR comments
commit d22aaf6
Author: Technobly <technobly@gmail.com>
Date: Fri Oct 22 15:13:34 2021 -0500
prevent a dependency issue causing a safe mode loop
commit f762226
Author: Technobly <technobly@gmail.com>
Date: Thu Sep 30 10:36:21 2021 -0500
Implements background modem update checks, Cellular.updateStatus(), Cellular.enableUpdates()
commit 3d09a76
Author: Technobly <technobly@gmail.com>
Date: Wed Sep 29 13:27:24 2021 -0500
rebase and whitespace fixes
commit 6c2f5e9
Author: Technobly <technobly@gmail.com>
Date: Mon Sep 27 10:34:43 2021 -0500
Move modem firmware version check to sara_ncp_client
commit ca5cd65
Author: Technobly <technobly@gmail.com>
Date: Tue Sep 21 17:21:37 2021 -0500
Revert "Remove more R510 FOTA support"
This reverts commit 532acce.
commit 59b5ec8
Author: Technobly <technobly@gmail.com>
Date: Mon Sep 20 17:13:28 2021 -0500
Revert "Remove R510 FOTA support"
This reverts commit a0b92dd.
commit 6ececed
Author: Technobly <technobly@gmail.com>
Date: Fri Sep 17 22:40:41 2021 -0500
Removes System feature FEATURE_NCP_FW_UPDATES and some cleanup
commit a78f8c1
Author: Technobly <technobly@gmail.com>
Date: Fri Sep 10 17:04:29 2021 -0500
Remove R510 support for Gen2
commit 82b8b9f
Author: Technobly <technobly@gmail.com>
Date: Fri Aug 13 09:57:55 2021 -0500
implements System feature FEATURE_NCP_FW_UPDATES and performs NCP FW update in Safe Mode
a1a35cf to
67d49f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
Details
develop-4.xand reverts the commits which removes FOTA supportR510 FOTA Process
R510 Firmware Update Background Check:
check if there is an update firmware version available.
R510 Firmware Update
a. waiting for final INSTALL URC of 128
b. polling for AT/OK every 10 seconds
c. monitoring a timeout counter of 40 minutes
Testing
Example App
References