Get CI into production-ready shape#1
Conversation
DanGould
force-pushed
the
pin-1-56
branch
4 times, most recently
from
7a803cb to
4a3a5b1
Compare
|
Can you explain the difference between 1.56 and 1.63 in the context of Kixunil#24 ? i'm not sure if the reason for bumping to 1.63 is simply that that's what rust-payjoin requires or if this is motivated by some code changes |
|
nothingmuch
left a comment
nothingmuch
left a comment
There was a problem hiding this comment.
This seems correct to me, so ACK, but I'm taking MSRV rationale at face value.
I would prefer silencing the remaining linting checks with an attr, so that it's easier to tell before CI if new warnings were introduced.
The error is only passed up via `source` when `std::error::Error` is available. When the feature is off, it's dead code.
The code isn't actually dead, and is used in the bytes() function, but the compiler's dead code analysis doesn't fully track usage through feature flags and doesn't count if the pattern isn't considered a read of the field.
|
|
2 participants
Uh oh!
There was an error while loading. Please reload this page.