Sender cancel state#1557
Draft
arminsabouri wants to merge 3 commits into
Draft
Conversation
arminsabouri
force-pushed
the
sender-cancel-state
branch
2 times, most recently
from
7cf2e7c to
d3dac67
Compare
Collaborator
Coverage Report for CI Build 25928742109Coverage decreased (-0.1%) to 85.195%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
If application manually cancels the assumption is they will not attempt to resume that session again. The session is marked closed. The cancel type leaves the session open and the session can only be closed once the user confirms they broadcasted the fallback tx -- or took an equivalent action.
If a user calls fallback {session_id} we first cancel
the session then fallback, and finally persist the outcome
which should close session
arminsabouri
force-pushed
the
sender-cancel-state
branch
from
d3dac67 to
cefae94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing @spacebear21 's idea from #1542 (comment)
for just the sender.
Recevier side is implemented here: #1558
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.
Claude made the updates to the payjoin-cli