Open
Conversation
Author
|
@pazz the workflow should pass now |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1588. Took inspiration from #1603.
Testing
I switched back and forth between a few different themes I have and visually it seemed to work great. I also was able to switch back to the default theme with
:theme default.theme.I switched to the same theme I was already using and verified that it didn't rebuild the buffer (e.g. the thread I was viewing didn't reset its collapsed state).
I tried loading
:theme doesntexistand saw the error message in the UI.I sabotaged one of my theme files and tried to load it. I saw an error message in the UI and this in the logs:
I added a few unittests for the
get_themefunction I wrote.Docs
I took a stab at updating the docs, but didn't try to build it or anything.I didn't realize the command docs were generated, fixed.