i_1287 Use correct value for scoreboard type enum

[johnbrvc]

Description of what the PR does

Do not use the enum member name PASSFAIL for the value of the enum, rather, use the getType() method to return the correct string (pass-fail). Previously, the toString() method was used and this returned the enum member name, not its value. These calls were changed to getType().

There appears to be more differences than there really are due to fixing lines with spaces only on them.

Issue which the PR addresses

Fixes #1287

Environment in which the PR was developed (OS,IDE, Java version, etc.)

Windows 11
java version "1.8.0_321"
Java(TM) SE Runtime Environment (build 1.8.0_321-b07)
Java HotSpot(TM) 64-Bit Server VM (build 25.321-b07, mixed mode)

Precise steps for testing the PR (i.e., how to demonstrate that it works correctly)

1. Load the clics_sumithello sample contest
2. Start the feeder1 event feed client and press the Start button.
3. Using a browser, browse to: https://administrator1:administrator1@localhost:50443/contests

[
  {
    "id": "SumH",
    "name": "Sumit Hello Sample",
    "formal_name": "The Sumit Hello Sample Contest",
    "start_time": null,
    "countdown_pause_time": null,
    "duration": "5:00:00",
    "scoreboard_freeze_duration": "1:00:00",
    "scoreboard_thaw_time": null,
    "scoreboard_type": "pass-fail",
    "penalty_time": 20
  }
]

Note the scoreboard_type property is pass-fail as required by the CLICS specification (not passfail).
4) Exit the feeder client and the server.
5) Delete the profiles folder and profiles.properties file to allow a clean restart.
6) Load the pointscoring sample contest.
7) Start the feeder1 event feed client and press the Start button.
8) Using a browser, browse to: https://administrator1:administrator1@localhost:50443/contests

[
  {
    "id": "pointscoring",
    "name": "pointscoring",
    "formal_name": "Point Scoring Contest",
    "start_time": "2026-08-10T11:50:25.677-04",
    "countdown_pause_time": null,
    "duration": "5:00:00",
    "scoreboard_freeze_duration": "1:00:00",
    "scoreboard_thaw_time": null,
    "scoreboard_type": "score",
    "penalty_time": 20
  }
]

Note the scoreboard_type property is score as required by the CLICS specification for point scoring contests.