Skip to content

hotfix(seo): crawl-allow /invite?invited_by= like /invite?code= #2835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xkkonrad wants to merge 1 commit into
base: main
Choose a base branch
from
Open

hotfix(seo): crawl-allow /invite?invited_by= like /invite?code= #2835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/constants/__tests__/seo-route-policy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,15 @@ describe('SEO route policy', () => {
expect(receivesNoindexHeader(route)).toBe(false)
})

it.each(['/home', '/home/activity', '/invite?code=abc&lid=campaign', '/api/og?type=send&username=alice&amount=10'])(
'renders a noindex header for %s through Next route matching',
async (route) => {
await expect(renderedRobotsHeader(route)).resolves.toBe('noindex, nofollow')
}
)
it.each([
'/home',
'/home/activity',
'/invite?code=abc&lid=campaign',
'/invite?invited_by=abc',
'/api/og?type=send&username=alice&amount=10',
])('renders a noindex header for %s through Next route matching', async (route) => {
await expect(renderedRobotsHeader(route)).resolves.toBe('noindex, nofollow')
})

it.each(['/lp', '/api/og/marketing?title=Peanut', '/m/stain', '/en/pay-with/pix'])(
'does not render a noindex header for %s through Next route matching',
Expand Down Expand Up @@ -107,6 +110,7 @@ describe('SEO route policy', () => {
'/setup$',
'/invite$',
'/invite?code=',
'/invite?invited_by=',
])
})
})
4 changes: 3 additions & 1 deletion src/constants/seo-route-policy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ const ROBOTS_DISALLOWED_PATHS = Object.freeze([
'/withdraw',
])

// GSC shows these exact shells (or their invite query variants) in Google's
// GSC shows these exact shells (or their invite query variants — ?invited_by=
// is what peanut-ui emits since ui#2828, ?code= the legacy alias) in Google's
// index. They need a narrow crawl exception so search engines can observe and
// refresh the X-Robots-Tag. Descendant transaction/profile URLs remain
// blocked. Keep the exceptions while these routes exist; only remove one once
Expand All @@ -89,6 +90,7 @@ const GOOGLE_DEINDEX_CRAWL_ALLOW_PATHS = Object.freeze([
'/setup$',
'/invite$',
'/invite?code=',
'/invite?invited_by=',
])

const NOINDEX_HEADER = Object.freeze({ key: 'X-Robots-Tag', value: 'noindex, nofollow' })
Expand Down
Loading