-
Notifications
You must be signed in to change notification settings - Fork 14
feat(withdraw): crypto address book — save, nickname, reuse destinations #2837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abalinda
wants to merge
7
commits into
dev
Choose a base branch
from
feat/crypto-address-book
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fac4b7d
feat(withdraw): crypto address book — save, nickname, reuse withdraw …
abalinda 2e110ea
fix(address-book): coerce numeric chain ids in the lookup key
abalinda 6b2e6f3
fix(address-book): code-review pass — token fallback, loading gate, d…
abalinda 101d8d0
fix(address-book): back from the method list returns to the book; use…
abalinda a9f24a7
style(address-book): last-used pill uses StatusBadge (DS success / at…
abalinda 83a418f
fix(withdraw): retry button honours the save-nickname gate too
abalinda 935a6cf
style(address-book): stale pill is grey, not red
abalinda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BLOCKING: Preserve the saved destination network
Tapping a saved Base entry sets chain 8453 here, but after the amount step opens /withdraw/crypto, InitialWithdrawView mounts with withdrawData still null and resets the token context to the Peanut wallet chain. Because both networks are EVM, the recipient remains valid and Review can send that address on Arbitrum instead of Base; Tron/Solana entries are cleared by the family-change effect instead. Carry the address-book selection into the crypto screen (or skip its default reset for an explicit prefill) and cover the row-to-review transition in a test.