-
Notifications
You must be signed in to change notification settings - Fork 14
feat(withdraw): tap the balance to withdraw everything #2842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 10 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b984cc9
feat(withdraw): tap the balance to withdraw everything
abalinda 09187b2
comment: name exponential notation as a case the inert balance row co…
abalinda ca67be6
fix(withdraw): keep the balance tap from opening the keyboard over th…
abalinda e959d37
feat(withdraw): underline only the amount, and fill it floored to cents
abalinda 29cd908
fix(ui): write the dollar symbol against the amount
abalinda b2cc434
a11y: floor the balance action's tap target width too
abalinda 149bae3
feat(withdraw): withdraw everything on crypto, still show two decimals
abalinda 6de65ff
docs: resolveWithdrawAmount does not clamp — say so
abalinda b2409d1
Merge origin/dev — resolve the balance row onto the DS-migrated Amoun…
abalinda 80c0b05
a11y(ds): keyboard focus ring on the balance action (law 8)
abalinda acc2b39
Merge remote-tracking branch 'origin/fix/21991-network-fee-one-source…
abalinda c92839b
fix(withdraw): quote a withdraw by what the user spends; gate the spe…
abalinda 75de393
Merge remote-tracking branch 'origin/fix/21991-network-fee-one-source…
abalinda db33891
Merge remote-tracking branch 'origin/fix/21991-network-fee-one-source…
abalinda 271f163
Merge remote-tracking branch 'origin/fix/21991-network-fee-one-source…
abalinda d7c82ce
Merge remote-tracking branch 'origin/fix/21991-network-fee-one-source…
abalinda 773b4ca
Merge branch 'dev' into feat/withdraw-use-full-balance
innolope-dev d828f61
Merge remote-tracking branch 'origin/fix/21991-network-fee-one-source…
innolope-dev c275e19
test(withdraw): assert the sub-minimum full-balance error on the fiel…
innolope-dev 6dd1ba4
Merge remote-tracking branch 'origin/fix/21991-network-fee-one-source…
innolope-dev 7361786
Merge remote-tracking branch 'origin/fix/21991-network-fee-one-source…
innolope-dev 280fe99
Merge remote-tracking branch 'origin/dev' into feat/withdraw-use-full…
innolope-dev c786437
fix(withdraw): latest-wins quoting, and gate on what the kernel actua…
innolope-dev 24518c7
fix(withdraw): freeze the spend with the charge instead of deriving i…
innolope-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BLOCKING: Bind the send amount to the prepared charge
The charge is created from the current
effectiveAmount, but this memo keeps deriving that amount from the live balance through Confirm andsendMoneyuses the new value. For example, prepare a max withdrawal at 10.126123 USDC, then let the balance fall to 10.121111 before Confirm; both floor to the displayed 10.12, so the resolver and gate accept 10.121111 while the request/charge still requires 10.126123. Funds move, then the API validator rejects the underpayment; on the trusted collateral path it instead completes and books the old requested amount. Freeze the exact spend once the charge is prepared, or rebuild the charge and route whenever that amount changes, and cover same-cent balance increases and decreases between Review and Confirm.