chore(native): iOS 16.4 floor, native Sentry request capture off, ACCESS_NETWORK_STATE - #2919
Conversation
…t capture, declare ACCESS_NETWORK_STATE The Tailwind v4 stylesheet needs WebKit 16.4 (@layer, oklab gradients, @Property), so the App Store must stop offering the binary to iOS 15.x. sentry-cocoa 9.26 captures failed requests by default, duplicating every 5xx the JS layer already reports. Without ACCESS_NETWORK_STATE the WebView always reports navigator.onLine=true, making the net_online tag meaningless on Android.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Code-analysis diffPainscore total: 7081.84 → 7081.84 (0) |
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
![chip-peanut-bot[bot]](https://avatars.githubusercontent.com/in/2915219?s=60&v=4){kind=small}
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
No actionable defects found in the pinned native-only diff. The platform floors, Sentry failed-request capture opt-out, and Android network-state permission are consistent with their release and runtime paths; CI is green at the exact head.
Checked clean
- Pinned worktree HEAD and merge base matched the supplied head and base SHAs.
- Reviewed all five changed files through correctness, security, adversarial, and slop passes.
- Confirmed all four Xcode project deployment targets are 16.4 and Capacitor 8.2 regenerates the SwiftPM platform as iOS v16 from that project target during cap sync.
- Confirmed Sentry Cocoa 9.26.0 defaults failed-request capture on and gates its network tracker on enableCaptureFailedRequests; the JS request wrapper separately reports non-OK responses.
- Confirmed Android WebView enables network-state auto-detection when ACCESS_NETWORK_STATE is granted, and the edited manifest is valid XML.
- All CI checks at the exact head completed successfully or were intentionally skipped; a duplicate cancelled bot-approval run has a successful counterpart.
- Native archive was not run locally because Xcode is unavailable on this host; the iOS release workflow remains the binary compile gate.
Second opinion by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only, so treat its findings as advice.
Third opinion: did not run — claude-failed(1): Warning: no stdin data received in 3s, proceeding without it. If piping from a slow command, redirect stdin explicitly: < /dev/null to skip, or wait longer.. This review is one reviewer short.
Exact head: 7949b4a90814 · Context: repo, ci, upstream · Took 9m
1 participant
Summary
Binary-only follow-ups from the 2026-09-01 native regression review (dev vs v1.1.0). No JS changes; nothing here ships over OTA — it takes effect at the next native release.
IPHONEOS_DEPLOYMENT_TARGET15.0 → 16.4,Package.swift.iOS(.v16); floors documented indocs/NATIVE-RELEASE.md@layer(WebKit ≥ 15.4), interpolates gradientsin oklab(≥ 16.2) and puts the@propertyfallback inside a layer (≥ 16.4). iOS 15.x devices would get an unstyled app; the fleet is entirely ≥ 16.7, so nobody is cut off. Android keepsminSdk 24; the documented floor is Chrome WebView ≥ 111, guarded at runtime by the JS canary in the companion OTA PR.AppDelegate.swift:options.enableCaptureFailedRequests = falseAndroidManifest.xml:ACCESS_NETWORK_STATEnavigator.onLine === true, so thenet_onlineSentry tag and the network-triage "offline" verdict are meaningless on Android. Normal permission, no prompt.Companion OTA PR (JS fixes #0, #3–#19, #22–#28 plus the setup sign-in, home menu and back-button items) follows separately.
Verification
xcodebuild/ gradle); nothing to run locally.