Skip to content

display population & popularity in geojson when debug flag enabled#1311

Merged
missinglink merged 1 commit into
masterfrom
debug_population_popularity
Jun 14, 2019
Merged

display population & popularity in geojson when debug flag enabled#1311
missinglink merged 1 commit into
masterfrom
debug_population_popularity

Conversation

@missinglink

Copy link
Copy Markdown
Member

as per the title, this PR allows developers to view the population and popularity information when the ?debug=true param is enabled.

@missinglink

Copy link
Copy Markdown
Member Author

related pelias/openstreetmap#493

@missinglink missinglink force-pushed the debug_population_popularity branch from 78adefe to 07db099 Compare June 14, 2019 10:02

@orangejulius orangejulius left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah. Frickin' finally!

@Joxit Joxit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@missinglink missinglink merged commit 3a23652 into master Jun 14, 2019
@missinglink missinglink deleted the debug_population_popularity branch June 14, 2019 12:09
@bboure

bboure commented Jun 19, 2019

Copy link
Copy Markdown
Member

Would it make sense to always expose popularity in the api?
This could be useful, for example, to display places differently depending on their popularity on a map? Like, with different pin size or colour.

@missinglink

Copy link
Copy Markdown
Member Author

I think it's best we hide it under the debug flag for now and see how it is, we can always make it public later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants