Reduce search query multi_match's neighbourhood boost#1438
Closed
orangejulius wants to merge 1 commit into
Closed
Conversation
Member
Author
|
I looked into this more, and for the Statue of Liberty in the Pelias build I was using at least, the Statue itself is in the WOF neighbourhood Southern Tip, which is similar, but not identical to the Liberty Island neighbourhood. Maybe we should look at having the "Southern Tip" neighbourhood removed, instead of merging this PR. |
Member
Author
|
The relevant neighbourhood here has been removed from WOF data after being deemed invalid. I don't think we need this PR in general, so I'm closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the venue popularity changes in pelias/openstreetmap#531, many venue results are improved.
However, our test for finding the Statue of Liberty, which corresponds to one of our oldest venue popularity related issues, was still showing the statue as the second result, after the ferry terminal on Liberty Island.
I traced this down to scoring boosts given to the ferry terminal because it's part of the Liberty Island neighbourhood, whereas the statue itself is not (for some reason).
In general, I don't think neighbourhoods should make this much of a difference in queries, so this PR reduces the boost given to those matches in search queries.
This doesn't break any other tests, and while we generally don't like to adjust settings for one particular test, I think this change is worth considering.